This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Update Manifest finder for apk splits#2065
Merged
WonderCsabo merged 2 commits intoOct 31, 2017
androidannotations:developandroidannotations/androidannotations:developfrom
dodgex:2034_update_manifest_finder_to_support_splitsCopy head branch name to clipboard
Merged
Update Manifest finder for apk splits#2065WonderCsabo merged 2 commits intoandroidannotations:developandroidannotations/androidannotations:developfrom dodgex:2034_update_manifest_finder_to_support_splitsCopy head branch name to clipboard
WonderCsabo merged 2 commits into
androidannotations:developandroidannotations/androidannotations:developfrom
dodgex:2034_update_manifest_finder_to_support_splitsCopy head branch name to clipboard
Conversation
…ifest.xml if APK splits are enabled
WonderCsabo
suggested changes
Oct 31, 2017
WonderCsabo
left a comment
Member
There was a problem hiding this comment.
Seems to be good, but we should definitely have some tests for this.
Member
Author
|
I extended the existing tests with paths for split builds |
WonderCsabo
approved these changes
Oct 31, 2017
|
I have the same problem using AA 4.4, shouldn't it be fixed in that version? |
|
Nevermind, I still had a custom androidManifestFile configuration, after deleting it it worked... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is aimed to fix #2034 and allow android annotations to work in projects that use apk splits.