Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

Fix AndroidManifest meta-data parsing#1956

Merged
dodgex merged 1 commit into
androidannotations:developandroidannotations/androidannotations:developfrom
simopete:1929_fix_meta_data_parsesimopete/androidannotations:1929_fix_meta_data_parseCopy head branch name to clipboard
Feb 20, 2017
Merged

Fix AndroidManifest meta-data parsing#1956
dodgex merged 1 commit into
androidannotations:developandroidannotations/androidannotations:developfrom
simopete:1929_fix_meta_data_parsesimopete/androidannotations:1929_fix_meta_data_parseCopy head branch name to clipboard

Conversation

@simopete

Copy link
Copy Markdown
Contributor

Implements #1929

@WonderCsabo WonderCsabo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not forget to update the license header (you have to add a new line for the copyright for the AndroidAnnotations project, check recently updated files).


public static final class MetaDataInfo {

private String name;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make these final?

@simopete simopete force-pushed the 1929_fix_meta_data_parse branch from bf6b14c to 21a144e Compare February 19, 2017 17:32
@WonderCsabo WonderCsabo requested a review from dodgex February 19, 2017 18:13
@dodgex dodgex merged commit 1041927 into androidannotations:develop Feb 20, 2017
@dodgex

dodgex commented Feb 20, 2017

Copy link
Copy Markdown
Member

Thank you!

@dodgex dodgex added this to the 4.3 milestone Feb 20, 2017
@simopete simopete deleted the 1929_fix_meta_data_parse branch February 28, 2017 19:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.