Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

Log tags need to be shorter than 24 chars according to android docume…#1739

Closed
ghost wants to merge 3 commits into
developandroidannotations/androidannotations:developfrom
unknown repositoryCopy head branch name to clipboard
Closed

Log tags need to be shorter than 24 chars according to android docume…#1739
ghost wants to merge 3 commits into
developandroidannotations/androidannotations:developfrom
unknown repositoryCopy head branch name to clipboard

Conversation

@ghost

@ghost ghost commented Mar 30, 2016

Copy link
Copy Markdown

@WonderCsabo

Copy link
Copy Markdown
Member

Thanks for this PR! We have the same problem in TransactionalHandler and OrmLiteDaoHandler? Can you fix those as well? And maybe you can extract this into a helper class as well for example LogHelper.

@ghost

ghost commented Mar 30, 2016

Copy link
Copy Markdown
Author

@WonderCsabo bump

@WonderCsabo

Copy link
Copy Markdown
Member

Thanks! Can i ask you to:

  • fix the header in the new class (the build is failed because of that)
  • please reword your commit messages per the contributor guide in the wiki
  • add an overload to the log helper method, which accepts a GeneratedClassHolder (so we can remove more code duplication)
  • squash the last commits

@WonderCsabo

Copy link
Copy Markdown
Member

@delta2wye can you update the PR?

@dodgex dodgex mentioned this pull request Jun 1, 2016
@WonderCsabo WonderCsabo closed this Jun 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.