Seems to be cool, i added two comments. Could you please rebase this onto develop?

Hello,

I am having some trouble with this change, it seems that this default value is mandatory. Unfortunately, I am getting my default value through a

    <MultiSelectListPreference android:key="@string/prefernce_key"
                                   android:title="@string/preference_title"
                                   android:dialogTitle="@string/dialog_title"
                                   android:entries="@array/preference_entries"
                                  android:entryValues="@array/preference_entries_values"
                                   android:defaultValue="@array/preference_default_entry_values"/>

so this change doesn't quite suit me. Can't you keep it as optional ? (by the way the comment in the DefaultStringSet still claims that

 * <p>
 * Use on methods in {@link SharedPref} annotated class. The generated method
 * will return an empty {@link java.util.Set} of Strings by default.
 * </p>

Cheers

The JavaDoc has to be updated for sure. But we require the default value on any @DefaultXXX annotation. You can just specify an empty array, the behavior will be the same before this change. Alternativaly, you can just remove the @DefaultStringSet annotation, but that way you cannot specify keyRes.

thanks for the response. I noticed that

value = {} 

does not work. (it does work but generates code that doesn't compile)

value = ""

does work, but it's not quite the same.

In version 3.3.2
a

new HashSet<String>(0)

would get generated,
In version 4.0 with

value = ""

we get a

new HashSet<String>(Arrays.asList(""))

and with

value = {}

we get a

new HashSet<String>(Arrays.asList())

(doesn't compile)

Thanks for checking! "" is shortcut for {""} so that is okay. But we should
handle the empty array. @dodgex wanna fix this?
On Nov 7, 2015 00:47, "athkalia" notifications@github.com wrote:

thanks for the response. I noticed that

value = {}

does not work. (it does work but generates code that doesn't compile)

value = ''" does work, but it's not quite the same.

In version 3.3.2
a

new HashSet(0)

would get generated,
In version 4.0 with

value = ""

we get a

new HashSet(Arrays.asList(""))

and with

we get a
```new HashSet<String>(Arrays.asList())

(doesn't compile)

—
Reply to this email directly or view it on GitHub
https://github.com/excilys/androidannotations/pull/1555#issuecomment-154579420
.

Last one, food for thought. Can't the @DefaultRes also add support for Set and link the default value to an R.array.* value ?

@WonderCsabo cant fix it before 15.11. and the i have to find time.

i created PR #1624 with a fix and javadoc update

@athkalia the empty array is now fixed thanks to @dodgex.

Mapping Android resources to pref default values is the behavior of the @DefaultRes annotation. I think we can extend it by supporting a resource string array as default value of a string set. Please open a new issue for that.

Lovely! Will do, thanks