Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

Properly override varags methods #1552

Merged
yDelouis merged 1 commit into from
Sep 19, 2015
Merged

Properly override varags methods #1552

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions 9 ...re/androidannotations/src/main/java/org/androidannotations/helper/APTCodeModelHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,8 +212,11 @@ public JMethod overrideAnnotatedMethod(ExecutableElement executableElement, Gene
method.generify(typeDeclaration.getKey(), typeDeclaration.getValue());
}

int i = 0;
for (VariableElement parameter : executableElement.getParameters()) {
addParamToMethod(method, parameter, JMod.FINAL, actualTypes);
boolean varParam = i == executableElement.getParameters().size() - 1 && executableElement.isVarArgs();
addParamToMethod(method, parameter, JMod.FINAL, actualTypes, varParam);
i++;
}

for (TypeMirror superThrownType : executableElement.getThrownTypes()) {
Expand Down Expand Up @@ -266,10 +269,10 @@ private JMethod findAlreadyGeneratedMethod(ExecutableElement executableElement,
return null;
}

private void addParamToMethod(JMethod method, VariableElement parameter, int mod, Map<String, TypeMirror> actualTypes) {
private void addParamToMethod(JMethod method, VariableElement parameter, int mod, Map<String, TypeMirror> actualTypes, boolean varParam) {
String parameterName = parameter.getSimpleName().toString();
JClass parameterClass = typeMirrorToJClass(parameter.asType(), actualTypes);
JVar param = method.param(mod, parameterClass, parameterName);
JVar param = varParam ? method.varParam(parameterClass.elementType(), parameterName) : method.param(mod, parameterClass, parameterName);
copyNonAAAnnotations(param, parameter.getAnnotationMirrors());
}

Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.