This repository was archived by the owner on Feb 26, 2023. It is now read-only.
If ContextCompat is available, use it to resolve drawables#1424
Merged
WonderCsabo merged 1 commit intoMay 22, 2015
Merged
If ContextCompat is available, use it to resolve drawables#1424WonderCsabo merged 1 commit into
WonderCsabo merged 1 commit into
Conversation
Member
|
Thanks! Can you squash the commits? Also please add two tests in a separate commit: one when ContextCompat is available and one when it is not. Then assert the generated code is correct. You can check out ActivityIntentFragmentTest for an example. |
Contributor
Author
|
@WonderCsabo please take a look. |
Member
There was a problem hiding this comment.
You can move this line to setUp from both test methods.
WonderCsabo
added a commit
that referenced
this pull request
May 22, 2015
If ContextCompat is available, use it to resolve drawables
Member
|
Nice PR, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tries to fix #1422.