Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

Allow support PreferenceFragment with @PreferenceScreen#1397

Closed
WonderCsabo wants to merge 3 commits into
androidannotations:developandroidannotations/androidannotations:developfrom
WonderCsabo:1396_supportPreferenceFragmentFromSupportLibraryWonderCsabo/androidannotations:1396_supportPreferenceFragmentFromSupportLibraryCopy head branch name to clipboard
Closed

Allow support PreferenceFragment with @PreferenceScreen#1397
WonderCsabo wants to merge 3 commits into
androidannotations:developandroidannotations/androidannotations:developfrom
WonderCsabo:1396_supportPreferenceFragmentFromSupportLibraryWonderCsabo/androidannotations:1396_supportPreferenceFragmentFromSupportLibraryCopy head branch name to clipboard

Conversation

@WonderCsabo

Copy link
Copy Markdown
Member

Implements #1396.

I decided to support two unofficial libraries.

DayS and others added 2 commits November 9, 2014 16:43
[maven-release-plugin] copy for tag androidannotations-3.3
@WonderCsabo WonderCsabo force-pushed the 1396_supportPreferenceFragmentFromSupportLibrary branch from f071b68 to 115f1ba Compare May 5, 2015 13:21

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't that be android.support.v4.preference.PreferenceFragment?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok nevermind. just saw that the next file had the support version.

@yDelouis

yDelouis commented May 8, 2015

Copy link
Copy Markdown
Contributor

I'm OK with the code. I can't test it right now. If you're confident, you can merge this PR.

@WonderCsabo WonderCsabo force-pushed the 1396_supportPreferenceFragmentFromSupportLibrary branch from 115f1ba to 24a547a Compare May 9, 2015 08:46
WonderCsabo added a commit that referenced this pull request May 9, 2015
Allow support PreferenceFragment with @PreferenceScreen
@WonderCsabo WonderCsabo closed this May 9, 2015
@WonderCsabo WonderCsabo deleted the 1396_supportPreferenceFragmentFromSupportLibrary branch May 9, 2015 10:52
@WonderCsabo WonderCsabo restored the 1396_supportPreferenceFragmentFromSupportLibrary branch May 9, 2015 10:52
@WonderCsabo WonderCsabo deleted the 1396_supportPreferenceFragmentFromSupportLibrary branch May 9, 2015 10:52
@WonderCsabo WonderCsabo added this to the 3.3.1 milestone May 9, 2015
@WonderCsabo

Copy link
Copy Markdown
Member Author

Rebased and merged as of a4c7488.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.