Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

Comment on generated-code property .#1361

Merged
WonderCsabo merged 1 commit into
androidannotations:developandroidannotations/androidannotations:developfrom
arnaudruffin:developarnaudruffin/androidannotations:developCopy head branch name to clipboard
Mar 30, 2015
Merged

Comment on generated-code property .#1361
WonderCsabo merged 1 commit into
androidannotations:developandroidannotations/androidannotations:developfrom
arnaudruffin:developarnaudruffin/androidannotations:developCopy head branch name to clipboard

Conversation

@arnaudruffin

Copy link
Copy Markdown

Added comment in LICENSE.txt and generated classes headers, as discussed in issue #1356.
I just specified that work including aa-generated code could be distributed under any license. Feel free to edit, of course.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe another \n here to separate the two unrelated statements?

@WonderCsabo

Copy link
Copy Markdown
Member

Thanks for the PR!

You have Checkstyle violations.

Can you amend the commit per my comments?

@arnaudruffin

Copy link
Copy Markdown
Author

I am on it :)

@WonderCsabo

Copy link
Copy Markdown
Member

Please squash the commits into one.

@arnaudruffin

Copy link
Copy Markdown
Author

Sorry about that. I am no Git expert. My --amend didn't work as expected but thanks to that I improved my "rebase" skills

WonderCsabo added a commit that referenced this pull request Mar 30, 2015
Comment on generated-code property
@WonderCsabo WonderCsabo merged commit d2a72c6 into androidannotations:develop Mar 30, 2015
@WonderCsabo

Copy link
Copy Markdown
Member

Thanks for the PR!

@WonderCsabo WonderCsabo added this to the 3.3 milestone Mar 30, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.