Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

Fix for Parcelable[] ClassCastException#1294

Merged
yDelouis merged 2 commits into
androidannotations:developandroidannotations/androidannotations:developfrom
WonderCsabo:1208_getParcelableArrayWonderCsabo/androidannotations:1208_getParcelableArrayCopy head branch name to clipboard
Apr 5, 2015
Merged

Fix for Parcelable[] ClassCastException#1294
yDelouis merged 2 commits into
androidannotations:developandroidannotations/androidannotations:developfrom
WonderCsabo:1208_getParcelableArrayWonderCsabo/androidannotations:1208_getParcelableArrayCopy head branch name to clipboard

Conversation

@WonderCsabo

Copy link
Copy Markdown
Member

Fixes #1208.

@WonderCsabo

Copy link
Copy Markdown
Member Author

@yDelouis please review this PR.

@WonderCsabo WonderCsabo force-pushed the 1208_getParcelableArray branch from b89aba7 to 9cc165e Compare March 22, 2015 16:21
@yDelouis

Copy link
Copy Markdown
Contributor

Could you take into account my comment and add a test ?

@WonderCsabo

Copy link
Copy Markdown
Member Author

9cc165e modifies the already existing test so it will behave like the Android code.

@yDelouis

Copy link
Copy Markdown
Contributor

Ok, but I didn't see any test where a Parcelable array is put in a bundle and restored from it.

@yDelouis

Copy link
Copy Markdown
Contributor

Sorry, I looked too quickly.

@WonderCsabo

Copy link
Copy Markdown
Member Author

@yDelouis i addressed your comment. I also moved 69002c5 to #1352, because that commit no longer needed for this fix, but it is still a good refactor.

@WonderCsabo WonderCsabo force-pushed the 1208_getParcelableArray branch from d8ea235 to c5cb93a Compare March 25, 2015 14:02
yDelouis added a commit that referenced this pull request Apr 5, 2015
Fix for Parcelable[] ClassCastException
@yDelouis yDelouis merged commit 5767f86 into androidannotations:develop Apr 5, 2015
@yDelouis

yDelouis commented Apr 5, 2015

Copy link
Copy Markdown
Contributor

Good work. Thanks.

@yDelouis yDelouis added this to the 3.3 milestone Apr 5, 2015
@WonderCsabo WonderCsabo deleted the 1208_getParcelableArray branch April 5, 2015 21:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ClassCastException when using @Extra with Parcelable[] objects

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.