This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Fix possible repeated SuppressWarning with @EView#1267
Merged
yDelouis merged 1 commit intoDec 6, 2014
androidannotations:developandroidannotations/androidannotations:developfrom
WonderCsabo:1262_viewHolderRepeatsSuppressWarningsWonderCsabo/androidannotations:1262_viewHolderRepeatsSuppressWarningsCopy head branch name to clipboard
Merged
Fix possible repeated SuppressWarning with @EView#1267yDelouis merged 1 commit intoandroidannotations:developandroidannotations/androidannotations:developfrom WonderCsabo:1262_viewHolderRepeatsSuppressWarningsWonderCsabo/androidannotations:1262_viewHolderRepeatsSuppressWarningsCopy head branch name to clipboard
yDelouis merged 1 commit into
androidannotations:developandroidannotations/androidannotations:developfrom
WonderCsabo:1262_viewHolderRepeatsSuppressWarningsWonderCsabo/androidannotations:1262_viewHolderRepeatsSuppressWarningsCopy head branch name to clipboard
Conversation
Contributor
|
I made some comments on the code style, but I'm ok with this PR. |
In case of @Eviews, we add a @SuppressWarnings annotation to the class. Since we also copy annotations from the annotated class, this can result in repeated annotations. This commit fixes the issue by only adding the annotation (or an annotation array member) if needed.
b49ca79 to
492769c
Compare
Member
Author
|
PR updated. However if you can, please comment on the PR diff instead of the individual commit so they show up in this PR comment page. |
yDelouis
added a commit
that referenced
this pull request
Dec 6, 2014
…essWarnings Fix possible repeated SuppressWarning with @eview
Member
Author
|
@yDelouis thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1262.
I would appreciate if someone could look at this. I think this is the most clear way to handle this, but one can never know. :)