What about if one wants to inject a simple Dao (not a RuntimeExceptionDao)?

then it still uses the helper.getDao().

Yeah, i see. Can you add a fixture to the test project which fails with the old behavior but works with this PR?

done

Something is not okay, this code generated:

try {
    userDao = databaseHelper_.getDao(User.class);
} catch (SQLException e) {
    Log.e("OrmLiteActivity_", "Could not create DAO userDao", e);
}
databaseHelper_.getRuntimeExceptionDao(Car.class);
databaseHelper_.getRuntimeExceptionDao(User.class);
try {
    carDao = databaseHelper_.getDao(Car.class);
} catch (SQLException e) {
    Log.e("OrmLiteActivity_", "Could not create DAO carDao", e);
}
ormLiteBean = OrmLiteBean_.getInstance_(this);

You forgot to assign the value in case of RuntimeExceptionDaos.

wtf. i'll fix that later or tomorrow depending on when i get the time.

wow this is such an awesome issue... no matter what you do. java wont let you cast these fckn RuntimeExceptionDao as it is class instead of interface. but i think i have another solution.

I do not really understand. As you said the return type is generic D extends RuntimeExceptionDao<T, ?>, so you do not have to cast at all. What am i missing?

BTW there is a note in the javadoc:

NOTE: This routing does not return RuntimeExceptionDao because of casting issues if we are assigning it to a custom DAO. Grumble.

not sure how to explain that. it compiles due to the generic returnt type. but it actualy ireturns only RuntimeExceptionDao

D castDao = (D) new RuntimeExceptionDao(dao);
return castDao;

so you have to cast a concrete class to a "higher level" class and that is impossible.

i now changed the code to do

try {
    runtimeExceptionDao = new RuntimeExceptionDao<Car, Long>((Dao<Car, Long>) databaseHelper_.getDao(Car.class));
} catch (SQLException e) {
    Log.e("OrmLiteActivity_", "Could not create DAO runtimeExceptionDao", e);
}
try {
    userRuntimeExceptionDao = new UserRuntimeExceptionDao((Dao<User, Long>) databaseHelper_.getDao(User.class));
} catch (SQLException e) {
    Log.e("OrmLiteActivity_", "Could not create DAO userRuntimeExceptionDao", e);
}

this works, but yields unchecked cast warnings as getDao returns Dao<T, ?>. not sure how to handle this warning.

and yes, the cast is required.

BTW are you sure this is needed? I just checked the source code of ORMLite, and for me it seems RuntimeExceptionDao.createDao and OrmLiteSqliteOpenHelper.getRuntimeExceptionDao create the normal dao, and they are just wrapping into a RuntimeExceptionDao. So a custom RuntimeExceptionDao class is not really supported.

with this PR, AA could support custom RuntimeExceptionDao.
not sure if this is needed. but i used custom ones in my code until now. and i just migrated to @OrmLiteDao instead of my custom code in my DatabaseHelper and got trouble with my RuntimeExceptionDaos. if you decide to not merge this PR as it adds features to AA that are not supported by the upstream project, i'm ok with this and will change to RuntimeExceptionDao<T,ID>-

I think you should ask about this in upstream first, and please reference the thread here.

i think that having a OrmLiteSqliteOpenHelper.getRuntimeExceptionDao() method that returns an custom class would require to pass this class to the and then use reflection to get the constructor and invoke it. and i'm not sure if this is something that should be desired on android.

Yes, you have to pass the custom class or declare it on the top of the entity class. Either way, reflection is required, but that is not a big deal since OrmLite already uses reflection to create the normal dao.

BTW, how did you used your custom RuntimeExceptionDao class before AA? 😕

i actually did what i have now in AA :D

public class DatabaseHelper extends OrmLiteSqliteOpenHelper {
private AlarmInfoDao alarmInfoDao;
//....
    public AlarmInfoDao getAlarmInfoDao() {
        if (alarmInfoDao == null) {
            try{
                alarmInfoDao = new AlarmInfoDao(getDao(AlarmInfo.class));
            } catch(SQLException e) {
                Log.e(DatabaseHelper.class.getName(), "can't get dao", e);
            }
        }
        return alarmInfoDao;
    }
//....
}

updated the pr and rebased. but also changed my code to use RuntimeExceptionDao.

I see. I just wanted to say you could just use getDao and wrap into the custom, but i see you already implemented that. 😏
This PR indeed adds a feature which is missing from the upstream project, but i think we can still add this, since upstream would also provide this use-case but cannot since it does not work at compile-time (at least if i interpret the javadoc correctly).

@yDelouis WDYT?

BTW @dodgex can you please ask whether our generated code is a good practice on the ORMLite mailing list or some other channel related to ORMLite?

@WonderCsabo https://groups.google.com/forum/#!topic/ormlite-android/wGPuUJV5j30

The generated code seems good to me.
But, we have to validate that, in case of a custom RuntimeExceptionDao, the class has the right constructor.

@yDelouis yeah. you are right...

https://github.com/excilys/androidannotations/blob/develop/AndroidAnnotations/androidannotations/src/main/java/org/androidannotations/helper/ValidatorHelper.java#L534 any one got an idea why there is that null check?

@dodgex if OrmLite classes are not on the classpath that reference will be null.

ah okay. so it would make sense to do this null check and error if this check is true (missing classes).

Here is the null check if is enough. indicating that the classes are missing is a responsibility of another method: hasOrmLiteJars.

ah ok.

added validation for constructor of custom subtypes of RuntimeExceptionDao.

Can you reword the first commit (as it now does other things as well). Also try to fit into the 50 char length summary, and add more detail in the commit body if needed (max 72 char length), as it is written in the contribution wiki page.

• reabased
• refactored to move code to OrmLiteHelper
• reworded first commit and PR title

Thanks. Can you update the wiki?

https://github.com/dodgex/androidannotations/wiki/Ormlite#runtimeexceptiondao done

Wiki merged, thanks.