This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Don't add the extra method in IntentBuilder with @ServiceAction#1214
Merged
WonderCsabo merged 1 commit intoNov 6, 2014
androidannotations:developandroidannotations/androidannotations:developfrom
yDelouis:1070_extraNotAddedByServiceActionInIntentBuilderyDelouis/androidannotations:1070_extraNotAddedByServiceActionInIntentBuilderCopy head branch name to clipboard
Merged
Don't add the extra method in IntentBuilder with @ServiceAction#1214WonderCsabo merged 1 commit intoandroidannotations:developandroidannotations/androidannotations:developfrom yDelouis:1070_extraNotAddedByServiceActionInIntentBuilderyDelouis/androidannotations:1070_extraNotAddedByServiceActionInIntentBuilderCopy head branch name to clipboard
WonderCsabo merged 1 commit into
androidannotations:developandroidannotations/androidannotations:developfrom
yDelouis:1070_extraNotAddedByServiceActionInIntentBuilderyDelouis/androidannotations:1070_extraNotAddedByServiceActionInIntentBuilderCopy head branch name to clipboard
Conversation
Member
There was a problem hiding this comment.
👍 Nice refactor on these two methods.
WonderCsabo
added a commit
that referenced
this pull request
Nov 6, 2014
…ionInIntentBuilder Don't add the extra method in IntentBuilder with @ServiceAction
Member
Member
|
Actually the created extra methods were never documented. But you are right, we should be clear. |
Member
|
hm. i think i'm not sure what you mean by "extra methods". |
Member
|
Please read the referenced issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves the issue #1070.