Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

override onNewIntent for @AfterExtras#1159

Merged
WonderCsabo merged 1 commit into
androidannotations:developandroidannotations/androidannotations:developfrom
dodgex:1157_override_onNewIntentCopy head branch name to clipboard
Sep 24, 2014
Merged

override onNewIntent for @AfterExtras#1159
WonderCsabo merged 1 commit into
androidannotations:developandroidannotations/androidannotations:developfrom
dodgex:1157_override_onNewIntentCopy head branch name to clipboard

Conversation

@dodgex

@dodgex dodgex commented Sep 23, 2014

Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should follow our convention, and name this getOnNewIntent, and return the JMethod.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the handler, you can create wrapper method or add a comment, so it is clear you "get" the method to just override it.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR updated.

WonderCsabo added a commit that referenced this pull request Sep 24, 2014
Override onNewIntent for @AfterExtras
@WonderCsabo WonderCsabo merged commit 6e21c27 into androidannotations:develop Sep 24, 2014
@WonderCsabo

Copy link
Copy Markdown
Member

Thanks.

@dodgex dodgex deleted the 1157_override_onNewIntent branch September 24, 2014 08:02
@WonderCsabo WonderCsabo added this to the 3.2 milestone Sep 29, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.