Add missing system services#1151
Add missing system services#1151WonderCsabo merged 1 commit intoandroidannotations:developandroidannotations/androidannotations:developfrom WonderCsabo:addMissingSystemServicesWonderCsabo/androidannotations:addMissingSystemServicesCopy head branch name to clipboard
Conversation
There was a problem hiding this comment.
This service shouldn't be commented out. We can still manually check that it is injected.
Only the test should be commented out.
There was a problem hiding this comment.
I comment this out because Robolectric prints messages to System.err about it. But if you think i can re-enable.
There was a problem hiding this comment.
I didn't notice. There is indeed a warning in the maven output.
I think we should enable it anyway because it can help us to see if the generated code at least compile.
|
Services not supported by Robolectric should be commented out only in the test class. |
3ef19c4 to
6d2c1a2
Compare
|
I updated the commit. Also i restored alphabetical order. |
Lot of system services were missing which are added in newer Android versions. Now AndroidAnnotations support those. Also added tests for all services, and commented out those which cannot be tested due to Android version or Robolectric issues.
5e8c128 to
1fee3bb
Compare
|
@yDelouis can we merge this? |
|
I think so. |
Add missing system services
Lot of system services were missing which are added in newer Android versions. Now AndroidAnnotations support those. Also added tests for all services, and commented out those which cannot be tested due to Android version or Robolectric issues.