Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

add: missing license headers#1120

Merged
WonderCsabo merged 1 commit into
androidannotations:developandroidannotations/androidannotations:developfrom
Artyomcool:suppose-thread-licenseArtyomcool/androidannotations:suppose-thread-licenseCopy head branch name to clipboard
Aug 31, 2014
Merged

add: missing license headers#1120
WonderCsabo merged 1 commit into
androidannotations:developandroidannotations/androidannotations:developfrom
Artyomcool:suppose-thread-licenseArtyomcool/androidannotations:suppose-thread-licenseCopy head branch name to clipboard

Conversation

@Artyomcool

Copy link
Copy Markdown

No description provided.

@WonderCsabo

Copy link
Copy Markdown
Member

You are unlucky. :) I just found another work for you: JavaDocs on the annotations. Please add JavaDocs in this PR as we already requested. Look at existing annotations for examples.

@Artyomcool

Copy link
Copy Markdown
Author

@WonderCsabo, let me create another PR for that, it would be much cleaner, IMHO.

@WonderCsabo

Copy link
Copy Markdown
Member

OK.

@Artyomcool

Copy link
Copy Markdown
Author

here: #1121

@WonderCsabo

Copy link
Copy Markdown
Member

This has merge conflicts. Can you resolve them?

@Artyomcool Artyomcool force-pushed the suppose-thread-license branch from 06539f3 to 7046026 Compare August 31, 2014 20:22
@Artyomcool

Copy link
Copy Markdown
Author

Done. Looks like today is a day of --force :)

@WonderCsabo

Copy link
Copy Markdown
Member

Thanks. BTW a little trick: run mvn license:check -fn to see what files lack the header. :) I know, this should be part of the build. It will be soon.

WonderCsabo added a commit that referenced this pull request Aug 31, 2014
@WonderCsabo WonderCsabo merged commit b413952 into androidannotations:develop Aug 31, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.