Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

FileAppender in LoggerContext is optional#1110

Merged
yDelouis merged 1 commit into
androidannotations:developandroidannotations/androidannotations:developfrom
WonderCsabo:fileAppenderOptionalWonderCsabo/androidannotations:fileAppenderOptionalCopy head branch name to clipboard
Dec 14, 2014
Merged

FileAppender in LoggerContext is optional#1110
yDelouis merged 1 commit into
androidannotations:developandroidannotations/androidannotations:developfrom
WonderCsabo:fileAppenderOptionalWonderCsabo/androidannotations:fileAppenderOptionalCopy head branch name to clipboard

Conversation

@WonderCsabo

Copy link
Copy Markdown
Member

Logging to the file now can be turned off in annotation processing options. It is still on by default.

This provides a workaround for #961.

@WonderCsabo WonderCsabo force-pushed the fileAppenderOptional branch 2 times, most recently from c9820de to 1445707 Compare August 29, 2014 09:58
@WonderCsabo

Copy link
Copy Markdown
Member Author

@yDelouis this makes a strange "error" and i do not know why. The problem is that the compile-time tests create an androidannotations.log file in the project folder, which has lots of entries. This file has not been created before this PR.

@WonderCsabo

Copy link
Copy Markdown
Member Author

@yDelouis @DayS i found no fix for the core issue, so this could be interesting.

@dodgex

dodgex commented Dec 9, 2014

Copy link
Copy Markdown
Member

i think this should be merged. while it is not an actual fix for the core issue, it can be a way to workaround the issue for those having issues with a locked logfile.

also having open PRs that are ready to merge and having no points against a merge feels bad 😜. so either merge or close.

@WonderCsabo

Copy link
Copy Markdown
Member Author

Yes, i do not like dangling PRs as well! Actually i think this feature can be also useful some people for other reasons.

BTW, i just checked the diff and it has syntax highlight now. Awesome! Now i only miss --follow-renames in GitHub, because currently we do not see any history before renames which is very annoying. :)

@dodgex

dodgex commented Dec 9, 2014

Copy link
Copy Markdown
Member

yeah. might be usefull for other cases to... like disabling the logfile just for the reason that you have not check it ever (like for me^^). i even had to search it in my gradle build directory to find it.

Logging to the file now can be turned off in annotation processing
options. It is still on by default.
yDelouis added a commit that referenced this pull request Dec 14, 2014
FileAppender in LoggerContext is optional
@yDelouis yDelouis merged commit 8d6702c into androidannotations:develop Dec 14, 2014
@yDelouis

Copy link
Copy Markdown
Contributor

Seems good to me.
May you add a note in the wiki ?

@yDelouis yDelouis added this to the 3.3 milestone Dec 14, 2014
@WonderCsabo WonderCsabo deleted the fileAppenderOptional branch December 15, 2014 09:07
@WonderCsabo

Copy link
Copy Markdown
Member Author

Done.

@WonderCsabo WonderCsabo mentioned this pull request Dec 16, 2014
@WonderCsabo

Copy link
Copy Markdown
Member Author

@yDelouis this has a regression: when running the compile-time tests, the androidannotations.log file is saved to the root of the androidannotations module.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.