Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Feb 26, 2023. It is now read-only.
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

findViewById called twice when using @ItemClick (and similar) on injected View #552

Copy link
Copy link
Closed
Closed
findViewById called twice when using @ItemClick (and similar) on injected View#552
Copy link
Labels
Enhancement
Milestone
3.1
@cosminstefanxp

Description

@cosminstefanxp
cosminstefanxp
opened on Apr 8, 2013
Issue body actions

When having a View injected (@ViewById) and also ataching an ItemClick Listener (@ItemClick), the findViewById method is called twice in the generated afterSetContentView_ method.

The downside is that findViewById is not a very cheap method, is it?

Example:
Class:

public class Class{
...
        @ViewById
        protected View placesList;

    @ItemClick(R.id.placesList)
    public void editPlace(Place place){}
...
}

Generated:

...
   private void afterSetContentView_() {
        placesList = ((ListView) findViewById(com.rallyberry.android.R.id.placesList));
        {
            AdapterView<?> view = ((AdapterView<?> ) findViewById(com.rallyberry.android.R.id.placesList));

...

Thanks and keep doing the great work you are doing!

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    Enhancement

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions
      Morty Proxy This is a proxified and sanitized view of the page, visit original site.