Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

Check for TypeKind.ERROR in addition to ErrorType#511

Merged
pyricau merged 1 commit into
androidannotations:developandroidannotations/androidannotations:developfrom
KoljaTM:450_Pref_not_processed_on_cleanKoljaTM/androidannotations:450_Pref_not_processed_on_cleanCopy head branch name to clipboard
Feb 27, 2013
Merged

Check for TypeKind.ERROR in addition to ErrorType#511
pyricau merged 1 commit into
androidannotations:developandroidannotations/androidannotations:developfrom
KoljaTM:450_Pref_not_processed_on_cleanKoljaTM/androidannotations:450_Pref_not_processed_on_cleanCopy head branch name to clipboard

Conversation

@KoljaTM

@KoljaTM KoljaTM commented Feb 27, 2013

Copy link
Copy Markdown

see #450

@pyricau

pyricau commented Feb 27, 2013

Copy link
Copy Markdown
Contributor

Thank you, I'll check it out. I do not have time today, but I will look at this.

@ghost ghost assigned pyricau Feb 27, 2013
@pyricau

pyricau commented Feb 27, 2013

Copy link
Copy Markdown
Contributor

Hum, I do not have any dev environment available right now. I checked the changes, checked the API, and also verified that we do not use ErrorType in the code. It would be nice to have a test to prove the bad behavior and check that this fixes it (a compiler test). However, I believe we can trust you on the fact that your change actually fixes the problem.

pyricau added a commit that referenced this pull request Feb 27, 2013
Check for TypeKind.ERROR in addition to ErrorType. Fixes #450
@pyricau pyricau merged commit 3f1802f into androidannotations:develop Feb 27, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.