Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

Stop validation when injectHelper invalidated the annotation (#1795)#1801

Merged
WonderCsabo merged 2 commits into
androidannotations:developandroidannotations/androidannotations:developfrom
dodgex:fix_IndexOutOfBoundException_in_validationCopy head branch name to clipboard
Jul 17, 2016
Merged

Stop validation when injectHelper invalidated the annotation (#1795)#1801
WonderCsabo merged 2 commits into
androidannotations:developandroidannotations/androidannotations:developfrom
dodgex:fix_IndexOutOfBoundException_in_validationCopy head branch name to clipboard

Conversation

@dodgex

@dodgex dodgex commented Jun 14, 2016

Copy link
Copy Markdown
Member

see #1795

@WonderCsabo

Copy link
Copy Markdown
Member

Lots of CS violatons. 😄

@WonderCsabo

Copy link
Copy Markdown
Member

Can you add a compile-time test case from the original issue?

@dodgex

dodgex commented Jun 15, 2016

Copy link
Copy Markdown
Member Author

.< :D

I grepped the if statement into the code and missed the spaces :/

@dodgex

dodgex commented Jun 16, 2016

Copy link
Copy Markdown
Member Author

i'll merge the commits - just used a free minute (hopefully) fix the CS violations from web :D

dodgex added 2 commits June 17, 2016 17:59
This should fail to compile as an injection via method requires at least one parameter
@dodgex

dodgex commented Jun 17, 2016

Copy link
Copy Markdown
Member Author

@WonderCsabo updated

@WonderCsabo WonderCsabo merged commit fd5527a into androidannotations:develop Jul 17, 2016
@WonderCsabo WonderCsabo added this to the 4.1 milestone Jul 17, 2016
@dodgex dodgex deleted the fix_IndexOutOfBoundException_in_validation branch August 3, 2016 14:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.