Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

fixes #1604#1619

Merged
WonderCsabo merged 2 commits into
androidannotations:developandroidannotations/androidannotations:developfrom
ened:fix/1604ened/androidannotations:fix/1604Copy head branch name to clipboard
Nov 11, 2015
Merged

fixes #1604#1619
WonderCsabo merged 2 commits into
androidannotations:developandroidannotations/androidannotations:developfrom
ened:fix/1604ened/androidannotations:fix/1604Copy head branch name to clipboard

Conversation

@ened

@ened ened commented Nov 9, 2015

Copy link
Copy Markdown
Contributor

Use ContextCompat for color & ColorStateList resources.

@WonderCsabo

Copy link
Copy Markdown
Member

Great, thanks! Can you create a superclass and move all common methods up to it from DrawableResHandler, ColorRestHandler and ColorStateListResHandler?

@ened

ened commented Nov 9, 2015

Copy link
Copy Markdown
Contributor Author

Yes how about ContextCompatAwareResHandler ?

@WonderCsabo

Copy link
Copy Markdown
Member

Sounds good!

@WonderCsabo

Copy link
Copy Markdown
Member

@ened is this ready to be reviewed?

@ened

ened commented Nov 10, 2015

Copy link
Copy Markdown
Contributor Author

@WonderCsabo yes please.

WonderCsabo added a commit that referenced this pull request Nov 11, 2015
Use proper method to resolve Color and ColorStateList
@WonderCsabo WonderCsabo merged commit d01274d into androidannotations:develop Nov 11, 2015
@WonderCsabo WonderCsabo added this to the 4.0 milestone Nov 11, 2015
@WonderCsabo

Copy link
Copy Markdown
Member

Great work! Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.