Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Feb 26, 2023. It is now read-only.
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

The order of the ancestor elements are random #1591

Copy link
Copy link
Closed
Closed
The order of the ancestor elements are random#1591
Copy link
Labels
Defect
@shiraji

Description

@shiraji
shiraji
opened on Oct 12, 2015
Issue body actions

While I was working with #1156, I found a strange behavior of AA with ancestors elements.
Here is a test case for ancestors elements.

@EActivity
@OptionsMenu(R.menu.menu_1)
public abstract class TopActivity extends AppCompatActivity {
}

@EActivity
@OptionsMenu(R.menu.menu_2)
public abstract class SubActivity extends TopActivity {
}

@EActivity
@OptionsMenu(R.menu.menu_main)
public class MainActivity extends SubActivity {
}

In this case, the generated code expected to be

public final class MainActivity_
    extends MainActivity
    implements HasViews
    ...

    @Override
    public boolean onCreateOptionsMenu(Menu menu) {
        MenuInflater menuInflater = getMenuInflater();
        menuInflater.inflate(com.github.shiraji.myapplication.R.menu.menu_1, menu);
        menuInflater.inflate(com.github.shiraji.myapplication.R.menu.menu_2, menu);
        menuInflater.inflate(com.github.shiraji.myapplication.R.menu.menu_main, menu);
        return super.onCreateOptionsMenu(menu);
    }
    ...

However, it "sometimes" generate this code.

public final class MainActivity_
    extends MainActivity
    implements HasViews
    ...

    @Override
    public boolean onCreateOptionsMenu(Menu menu) {
        MenuInflater menuInflater = getMenuInflater();
        menuInflater.inflate(com.github.shiraji.myapplication.R.menu.menu_2, menu);
        menuInflater.inflate(com.github.shiraji.myapplication.R.menu.menu_1, menu);
        menuInflater.inflate(com.github.shiraji.myapplication.R.menu.menu_main, menu);
        return super.onCreateOptionsMenu(menu);
    }
    ...

If there is grand-parents class, the order of the ancestor elements are random. This is because how AA traverses and stores ancestors. Now, I am ready for pull request for this issue. Could you confirm this is a problem?

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    Defect

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions
      Morty Proxy This is a proxified and sanitized view of the page, visit original site.