Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

Patch for Rest#1587

Merged
WonderCsabo merged 6 commits into
androidannotations:developandroidannotations/androidannotations:developfrom
simopete:1333_Patch_for_Restsimopete/androidannotations:1333_Patch_for_RestCopy head branch name to clipboard
Oct 10, 2015
Merged

Patch for Rest#1587
WonderCsabo merged 6 commits into
androidannotations:developandroidannotations/androidannotations:developfrom
simopete:1333_Patch_for_Restsimopete/androidannotations:1333_Patch_for_RestCopy head branch name to clipboard

Conversation

@simopete

@simopete simopete commented Oct 10, 2015

Copy link
Copy Markdown
Contributor

Implements #1333

Some test are missing because PATCH is only available in Spring Android Rest Template 2.0

WonderCsabo added a commit that referenced this pull request Oct 10, 2015
@WonderCsabo
Merge pull request #1587 from simopete/1333_Patch_for_Rest
873f6d1 
Add @rest in REST client
@WonderCsabo WonderCsabo merged commit 873f6d1 into androidannotations:develop Oct 10, 2015
@WonderCsabo WonderCsabo added this to the 4.0 milestone Oct 10, 2015
@WonderCsabo

WonderCsabo commented Oct 10, 2015

Copy link
Copy Markdown
Member

I decided to merge this PR without explicit tests for @Patch. Actually that is just like POST, so its functionality is already tested, and this PR also paves the way for other features (@QueryMap, requreid annotations for all method params). We could switch our test suite to use Spring Android 2.0, however i am not sure about that, because it is still not released, and we cannot use milestone or snapshot dependencies. @yDelouis WDYT?

@WonderCsabo

WonderCsabo commented Oct 10, 2015

Copy link
Copy Markdown
Member

@simopete great work, thanks! Can you update the wiki? Please note the Part and Field annotations should be moved to a new section.

@WonderCsabo WonderCsabo mentioned this pull request Oct 11, 2015
Merged
@WonderCsabo

WonderCsabo commented Oct 18, 2015

Copy link
Copy Markdown
Member

Wiki merged, thanks!

@simopete simopete deleted the 1333_Patch_for_Rest branch March 20, 2016 14:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@simopete @WonderCsabo @dodgex
Morty Proxy This is a proxified and sanitized view of the page, visit original site.