This repository was archived by the owner on Feb 26, 2023. It is now read-only.

Allow android.support{v7,v14} for @PreferenceXXX#1545

Merged

yDelouis merged 1 commit into

androidannotations:developfrom

WonderCsabo:1535_supportV7PreferenceFragment

Sep 20, 2015

WonderCsabo commented Sep 11, 2015

Member

Fixes #1535.

WonderCsabo force-pushed the 1535_supportV7PreferenceFragment branch from e790cfe to 335181e Compare

September 11, 2015 22:13

yDelouis reviewed

View reviewed changes

...ain/java/org/androidannotations/internal/core/handler/AbstractPreferenceListenerHandler.java Outdated

yDelouis Sep 19, 2015

Contributor

This code :

holder.usingSupportV7Preference() ? getClasses().SUPPORT_V7_PREFERENCE : getClasses().PREFERENCE;

is repeated at least three times in the code. Maybe we could add a method JClass getPreferenceClass() in HasPreferences.

yDelouis commented Sep 19, 2015

Contributor

It is good, but has some duplicated code.


          Allow android.support{v7,v14} for @PreferenceXXX

7d5e870

WonderCsabo force-pushed the 1535_supportV7PreferenceFragment branch from 335181e to 7d5e870 Compare

September 19, 2015 21:19

WonderCsabo commented Sep 19, 2015

Member Author

@yDelouis updated.

yDelouis added a commit that referenced this pull request


          Merge pull request #1545 from WonderCsabo/1535_supportV7PreferenceFra…

ecdd9b3

…gment

Allow android.support{v7,v14} for @PreferenceXXX

yDelouis merged commit ecdd9b3 into androidannotations:develop

yDelouis commented Sep 20, 2015

Contributor

Thanks !

WonderCsabo deleted the 1535_supportV7PreferenceFragment branch

September 20, 2015 11:50

WonderCsabo added this to the 4.0 milestone

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet