allow sublcasses as parameters (#1285)#1441
allow sublcasses as parameters (#1285)#1441WonderCsabo merged 15 commits intoandroidannotations:developandroidannotations/androidannotations:developfrom dodgex:1285_allow_sublcasses_as_parametersCopy head branch name to clipboard
Conversation
|
knowing that it will take some time, i think almost all event binding annotations could benefit from this... that would allow to use custom classes as parameter without the need to cast. |
|
Thanks for this contribution! First, this was assigned to me. Don't take me wrong, i am not "jealous" that you took "my" job, but the opposite! 😉 However, next time can you ping me before start working, to avoid possible parallel work? Luckily, i did not start working on this, yet. To answer your question: most of the event binding annotations would benefit from this. However i think the |
There was a problem hiding this comment.
I do not think this is necessary. The isSubtype() JavaDoc says:
Any type is considered to be a subtype of itself.
|
hey @WonderCsabo. sorry for taking your job! ;) i haven't checked if someone is assigned just if there is a PR... :p I actually started doing the event binding annotations. as it is (at least until now) a simple task i'll do all of them. regardig #1076 i think i can add that here too. :) |
There was a problem hiding this comment.
Since the extendsType validation passed, at this point typeElement cannot be null.
|
Great, thanks! |
|
@WonderCsabo I'd never forget the JavaDoc... documentation is always the most fun part of coding! :/ |
|
wtf how got the |
|
pushed the latest code. sadly have to leave for now. #1076 has to wait a little. as far as i saw so far, it takes some more time than these small changes. i'll do it but i'm not sure if i can get to it today or if it has to wait for the weekend. |
|
You rebased onto the wrong commit, and rewrite my first commit. Simply
rebase again onto the real develop, and skip the first commit.
|
|
OK, i think i will review this branch as-is then merge, since it already has much commits. |
|
removed the invalid commit |
|
i hope i cought all comments. |
There was a problem hiding this comment.
I think you are not using this at all.
|
This looks really nice. I only have some final comments on a couple of things you missed. |
|
last two comments adressed. :) |
Allow subclasses as parameters
|
This is just great. I am sorry but can i ask you to update the wiki later as well? |
|
duh :/ |
|
wiki updated. i think #1285 can be closed now. |
|
New doc |
|
no, i just added it accidently to |
|
Wiki merged. Thanks for all your work on this! |
see #1285
i started with
@PreferenceClickand@PreferenceChangefeel free to hint for other annotations where this would be usefull!