I think the first commit is accidental. Also, you have checkstyle violations.

There is a problem: activityCompilesOnMinSdk21WithoutContextCompat and activityCompilesOnMinSdkLower21CompileSdkHigher21WithoutContextCompat fail, because ActivityIntentBuilder.hasActivityOptionsInFragment returns true, hence generates a call to a version of startActivityForResult which does not exist and a compilation error is raised. However i am not really sure why the test can find that kind of Fragment class in the classpath at all. 😕

Unfortunately I'm not able to reproduce the failing test for activityCompilesOnMinSdk21WithoutContextCompat or activityCompilesOnMinSdkLower21CompileSdkHigher21WithoutContextCompat as mentioned by you.

No, I'm using TextMate & maven for this. Any chance you can help me out for the Eclipse-testing part, please? ;-)

OK, i found out what is the problem with the classpath. The POM defines 4.1.1.4 version of the Android dependency. However, in our setup, we also add the eclipse-dependencies project to the classpath, which brings android 1.6 dependency, and overrides 4.1.1.4. That is why Eclipse cannot find the newer Activity methods. Maven does, because we do not have the eclipse-dependencies in Maven builds obviously.

Actually the POM also defined the 1.6 version Android dep, but 1b9f70e changed it to 4.1.1.4. I think it was a bad idea, because in our tests, we simulate we do not have Fragment in classpath, then we simulate we have it and add it manually. If we have 4.1.1.4 in the test classpath, we cannot simulate the cases without Fragment, and adding that manually makes no sense. @yDelouis, you are the author of that commit, i think we should revert the version incrementation. That means we have to change some tests, though.

@ened i think we should refactor ResHandler in a separate commit. We should make it abstract, and the process method should call an abstract processResource method and pass it idRef etc. Just like AbstractListenerHandler. Then create AnimationResHandler, DrawableResHandler etc, and a DefaultResHandler. Then register the correct classes in AnnotationHandlers. This way we do not mix the different cases into one class as we do now.

@WonderCsabo got it.

@ened please squash the current two commits.

@ened did you read #1427 (comment)?

@WonderCsabo yes, I'm on it, later tonight hopefully.

OK, thanks, just add some reactions to let me know you saw it. :)

@WonderCsabo added the abstraction. Regarding the "missing" unit test, it turns out we have it already, I think: activityCompilesWithRegularDrawable.

Thanks for creating an abstraction. However, that should have go in a separate commit. Any chance you can split the commit into two?