Make it clear Cookies in NativeCookieHandler are not to be changed. - #187
#187Closed
ncruces wants to merge 1 commit into
anaisbetts:masteranaisbetts/ModernHttpClient:masterfrom
ncruces:masterCopy head branch name to clipboard
Closed
Make it clear Cookies in NativeCookieHandler are not to be changed.#187ncruces wants to merge 1 commit intoanaisbetts:masteranaisbetts/ModernHttpClient:masterfrom ncruces:masterCopy head branch name to clipboard
ncruces wants to merge 1 commit into
anaisbetts:masteranaisbetts/ModernHttpClient:masterfrom
ncruces:masterCopy head branch name to clipboard
Conversation
fabionuno
added a commit
to fabionuno/ModernHttpClient
that referenced
this pull request
Nov 20, 2015
Make it clear Cookies in NativeCookieHandler are not to be changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making the Cookies property in NativeCookieHandler an IReadOnlyList makes it clearer that you can't set cookies by adding one to the list.