Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix check_for_page_caching() to account for wp_remote_retrieve_header() returning arrays#6938

Merged
westonruter merged 1 commit into
developampproject/amp-wp:developfrom
fix/page-caching-test-header-arraysampproject/amp-wp:fix/page-caching-test-header-arraysCopy head branch name to clipboard
Mar 4, 2022
Merged

Fix check_for_page_caching() to account for wp_remote_retrieve_header() returning arrays#6938
westonruter merged 1 commit into
developampproject/amp-wp:developfrom
fix/page-caching-test-header-arraysampproject/amp-wp:fix/page-caching-test-header-arraysCopy head branch name to clipboard

Conversation

@westonruter

Copy link
Copy Markdown
Member

Fixes #6937.

@westonruter westonruter added this to the v2.2.2 milestone Feb 24, 2022
@github-actions

github-actions Bot commented Feb 24, 2022

Copy link
Copy Markdown
Contributor

Plugin builds for 37d9c19 are ready 🛎️!

Comment thread tests/php/src/Admin/SiteHealthTest.php Outdated
@westonruter
westonruter force-pushed the fix/page-caching-test-header-arrays branch from 8058ae4 to 37d9c19 Compare March 3, 2022 16:48

@dhaval-parekh dhaval-parekh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.

@westonruter
westonruter merged commit b1430f9 into develop Mar 4, 2022
@westonruter
westonruter deleted the fix/page-caching-test-header-arrays branch March 4, 2022 17:05
westonruter added a commit that referenced this pull request Mar 4, 2022
manuelRod added a commit to manuelRod/performance that referenced this pull request Mar 30, 2022
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changelogged Whether the issue/PR has been added to release notes. Site Health

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Site Health test for page caching does not account for wp_remote_retrieve_header() returning arrays

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.