fix: use context manager for file handle in evaluate_ner() (Fixes #597) - #598
#598Open
rtmalikian wants to merge 1 commit into
allenai:mainallenai/scispacy:mainfrom
rtmalikian:fix/issue-597-unclosed-file-handlertmalikian/scispacy:fix/issue-597-unclosed-file-handleCopy head branch name to clipboard
Open
fix: use context manager for file handle in evaluate_ner() (Fixes #597)#598rtmalikian wants to merge 1 commit intoallenai:mainallenai/scispacy:mainfrom rtmalikian:fix/issue-597-unclosed-file-handlertmalikian/scispacy:fix/issue-597-unclosed-file-handleCopy head branch name to clipboard
rtmalikian wants to merge 1 commit into
allenai:mainallenai/scispacy:mainfrom
rtmalikian:fix/issue-597-unclosed-file-handlertmalikian/scispacy:fix/issue-597-unclosed-file-handleCopy head branch name to clipboard
Conversation
The evaluate_ner() function in train_utils.py opened a file handle with open(dump_path, 'a+') but never closed it, passing it directly to json.dump(). This is a resource leak and risks data loss since the written data may not be flushed to disk. Fixed by wrapping the open() call in a with statement to ensure the file handle is properly closed after writing. Signed-off-by: Raphael Malikian <rtmalikian@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #597
Problem
In
scispacy/train_utils.pyline 29,evaluate_ner()passes a rawopen()call directly tojson.dump():The file handle is never explicitly closed. This is a resource leak that can cause:
Fix
Wrapped the
open()call in awithstatement:This ensures the file handle is properly closed and flushed after writing.
Verification
ast.parse()passesChangelog
Files Changed
scispacy/train_utils.py— Replaced bareopen()withwithstatementVerification
python3 -c "import ast; ast.parse(open('scispacy/train_utils.py').read())"— syntax OKAbout the Author: Raphael Malikian — Clinical AI Solutions Architect. I specialise in building and fixing AI/ML systems for healthcare, including vector databases, RAG pipelines, and clinical NLP. If you need help with your project or think I can add value to your organisation, feel free to reach out — I'd love to connect.
📧 rtmalikian@gmail.com
🔗 GitHub: https://github.com/rtmalikian
🔗 LinkedIn: http://www.linkedin.com/in/raphael-t-malikian-mbbs-bsc-hons-71075436a
Disclosure: This code was developed with assistance from MiMo-v2.5-Pro (Xiaomi) via Hermes Agent (Nous Research). All changes were reviewed, tested against the actual codebase, and verified for correctness.