Added for saving git info - #5701
#5701Added for saving git info#5701Shreyz-max wants to merge 8 commits into
Conversation
|
Looks good. Can you also add a changelog entry? |
Do you mean adding it into the changelog? |
|
Yes, sorry for the typo. Autocorrect, am I right? 😅 |
|
Haha, happens to the best of us. |
Head branch was pushed to by a user without write access
|
Hey @dirkgr this is my first time working on open source and I think by mistake I disabled auto-merge. Also, I have no clue why the tests are not passing. Could you give me some ideas on where and how to start? It will be really helpful. |
|
I think auto-merge automatically disables itself when you make a change. Otherwise anyone could push to the branch and it would get merged. It's a safety feature in GitHub. Let's see if those tests are even still failing. |
|
I'm afraid this is a real test failure. The tests now seem to require your git repo to be in a very defined state. We can't have that. It breaks our own tests, and it'll certainly break the tests that @h-vetinari runs in conda-forge. |
|
So what should be done next? |
|
Look at the error and decide on a path to fix it. It looks to me like it's trying to determine the name of the current branch. What should happen if there isn't a current branch? What should happen if the code is run outside of a git repository? |
Change proposed in this pull request:
Saving git repo infos in meta class along with metadata of model archives after going through #4862 issue
Before submitting
section of the
CONTRIBUTINGdocs.Writing docstrings section of the
CONTRIBUTINGdocs.After submitting
codecov/patchreports high test coverage (at least 90%).You can find this under the "Actions" tab of the pull request once the other checks have finished.