Graylog Provider#4
Merged
Merged
Graylog Provider#4
Conversation
jahunt1
commented
Jul 18, 2017
Contributor
- Changed attribute accessor in AnalyticsEvent to return Map instead of HashMap
- new provider for Graylog HTTP inputs
- some Javadoc updates
added 4 commits
June 29, 2017 17:13
simon1867
approved these changes
Jul 19, 2017
| //noinspection unchecked | ||
| sb.append(jsonAttribute).append("\": ").append(getJsonFromMapRecursive((Map<String, Object>) attributeValue)); | ||
| } | ||
| else if (attributeValue instanceof Integer || |
Contributor
There was a problem hiding this comment.
seems like you could have an isNumber() method that would return a boolean and execute this OR statement and use it in the 3 spots that do this check
Contributor
Author
There was a problem hiding this comment.
Such better. Very wisdom.
|
|
||
| try | ||
| { | ||
| Thread.sleep(50); |
Contributor
There was a problem hiding this comment.
is there a need to sleep here if you're having the lock wait on the next couple of lines?
Contributor
Author
There was a problem hiding this comment.
Nope. At one point I was validating that we get a positive duration on the timed event, but now that the event gets serialized I don't care about parsing the JSON I would get out of the callback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.