Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Readme Updated#93

Closed
AleksaZatezalo wants to merge 14 commits into
alessandromaggio:masteralessandromaggio/pythonping:masterfrom
AleksaZatezalo:masterAleksaZatezalo/pythonping:masterCopy head branch name to clipboard
Closed

Readme Updated#93
AleksaZatezalo wants to merge 14 commits into
alessandromaggio:masteralessandromaggio/pythonping:masterfrom
AleksaZatezalo:masterAleksaZatezalo/pythonping:masterCopy head branch name to clipboard

Conversation

@AleksaZatezalo

Copy link
Copy Markdown
Contributor

What has been added to README.md includes:

  1. A description of the folder structure, and code structure via UML Diagrams, and a short description of the corresponding classes.
  2. A description of how to run testcases before opening a pull request.
  3. Generic guidelines on coding style.

@AleksaZatezalo

Copy link
Copy Markdown
Contributor Author

Wrong thing in readme.

@AleksaZatezalo

Copy link
Copy Markdown
Contributor Author

Wrong instruction regarding test bench.

alessandromaggio added a commit that referenced this pull request Oct 25, 2022
Allow count greater than 16-bit, fix pylint issues, update and expand readme
alessandromaggio added a commit that referenced this pull request Oct 25, 2022
* fix(icmp.py): ICMP header format string

All values in the struct should be unsigned.

* pylint issues resolved

Fixed a bunch of pylint issues

* First Readme push headers updated.

* Update README.md

* Update README.md

* UMLs created.

* UMLs created.

* Folder Structure Created.

* backticks added.

* Supporting words added.

* Grammer fix

* Code Styles section finished.

* Fix made

* Fix made

* Readme fixed.

* Readme fixed.

* Ready for pull request.

* Finally ready for pull request.

* Testcase added,

* feat: integrate #89, #92, and #93

Allow count greater than 16-bit, fix pylint issues, update and expand readme

Co-authored-by: David A. Bell <8835326+dabell-cc@users.noreply.github.com>
Co-authored-by: Mark Mayo <mark@there.co.nz>
Co-authored-by: Aleksa Zatezalo <aleksa@kali.azatezalo>
Co-authored-by: Aleksa Zatezalo <59803757+AleksaZatezalo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.