Restructure responses#5
Merged
alessandromaggio merged 9 commits intoJun 14, 2018
developalessandromaggio/pythonping:developfrom
restructure-responsesalessandromaggio/pythonping:restructure-responsesCopy head branch name to clipboard
Merged
Restructure responses#5alessandromaggio merged 9 commits intodevelopalessandromaggio/pythonping:developfrom restructure-responsesalessandromaggio/pythonping:restructure-responsesCopy head branch name to clipboard
alessandromaggio merged 9 commits into
developalessandromaggio/pythonping:developfrom
restructure-responsesalessandromaggio/pythonping:restructure-responsesCopy head branch name to clipboard
Conversation
Added payload_provider module, prepared the structure for the executor that will launch pings.
Now responses can be represented as human-readable, stastistics automatically update
Response now understands if the received message is an Echo Reply or a Destination Unreachable message. In the latter, it returns information about the error code. Optimized the succes property. The Destination Unreachable messages are still untested.
Added full test coverage for payload_provider and utils modules
Implemented the logic of sequence number (still unverified)
Completed tests for the Executor module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Responses are now paresed and tested.