Upgrade the deprecated GitHub Actions set-output workflow command syntax#8339
Merged
webknjaz merged 5 commits intoApr 18, 2024
aio-libs:masteraio-libs/aiohttp:masterfrom
Olegt0rr:actions-cache-updateOlegt0rr/aiohttp:actions-cache-updateCopy head branch name to clipboard
Merged
Upgrade the deprecated GitHub Actions set-output workflow command syntax#8339webknjaz merged 5 commits intoaio-libs:masteraio-libs/aiohttp:masterfrom Olegt0rr:actions-cache-updateOlegt0rr/aiohttp:actions-cache-updateCopy head branch name to clipboard
set-output workflow command syntax#8339webknjaz merged 5 commits into
aio-libs:masteraio-libs/aiohttp:masterfrom
Olegt0rr:actions-cache-updateOlegt0rr/aiohttp:actions-cache-updateCopy head branch name to clipboard
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8339 +/- ##
=======================================
Coverage 97.55% 97.55%
=======================================
Files 107 107
Lines 33069 33069
Branches 3882 3882
=======================================
Hits 32260 32260
Misses 589 589
Partials 220 220
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
10 tasks
Member
webknjaz
approved these changes
Apr 16, 2024
webknjaz
left a comment
Member
There was a problem hiding this comment.
The change is correct but I've stated a few style preferences FTR.
set-output workflow command syntax
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
Contributor
Author
|
Please, re-run failed jobs - there's trouble with coverage upload (it needs some retries). |
Contributor
Backport to 3.9: 💚 backport PR created✅ Backport PR branch: Backported as #8348 🤖 @patchback |
patchback Bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
…yntax Updating the way of saving output for cache path, cause [GitHub Actions deprecating save-state and set-output commands](https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/) PR #8339 Co-authored-by: Sviatoslav Sydorenko <sviat@redhat.com> (cherry picked from commit c26f356)
5 tasks
Contributor
Backport to 3.10: 💚 backport PR created✅ Backport PR branch: Backported as #8349 🤖 @patchback |
patchback Bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
…yntax Updating the way of saving output for cache path, cause [GitHub Actions deprecating save-state and set-output commands](https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/) PR #8339 Co-authored-by: Sviatoslav Sydorenko <sviat@redhat.com> (cherry picked from commit c26f356)
5 tasks
webknjaz
pushed a commit
that referenced
this pull request
Apr 19, 2024
…ns `set-output` workflow command syntax (#8348) **This is a backport of PR #8339 as merged into master (c26f356).** Updating the way of saving output for cache path, cause [GitHub Actions deprecating save-state and set-output commands](https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/)
webknjaz
pushed a commit
that referenced
this pull request
Apr 19, 2024
…ons `set-output` workflow command syntax (#8349) **This is a backport of PR #8339 as merged into master (c26f356).** Updating the way of saving output for cache path, cause [GitHub Actions deprecating save-state and set-output commands](https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Updating the way of saving output for cache path, cause
GitHub Actions deprecating save-state and set-output commands
Are there changes in behavior for the user?
No
Is it a substantial burden for the maintainers to support this?
Related issue number
No
Checklist
CONTRIBUTORS.txtCHANGES/foldername it
<issue_or_pr_num>.<type>.rst(e.g.588.bugfix.rst)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature: A new behavior, public APIs. That sort of stuff..deprecation: A declaration of future API removals and breakingchanges in behavior.
.breaking: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc: Notable updates to the documentation structure or buildprocess.
.packaging: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.