fix(gate): fast UI gate runs the AppSidebar test — nav-count gate-parity (final-acceptance park)#183
Open
agjs wants to merge 1 commit into
mainagjs/tsforge:mainfrom
fix/fast-gate-sidebar-parityagjs/tsforge:fix/fast-gate-sidebar-parityCopy head branch name to clipboard
Open
fix(gate): fast UI gate runs the AppSidebar test — nav-count gate-parity (final-acceptance park)#183agjs wants to merge 1 commit intomainagjs/tsforge:mainfrom fix/fast-gate-sidebar-parityagjs/tsforge:fix/fast-gate-sidebar-parityCopy head branch name to clipboard
agjs wants to merge 1 commit into
mainagjs/tsforge:mainfrom
fix/fast-gate-sidebar-parityagjs/tsforge:fix/fast-gate-sidebar-parityCopy head branch name to clipboard
Conversation
…parity) — build39 final-acceptance park build39 Company passed the fast per-feature gate (verified 1/1) but FAILED final acceptance on AppSidebar.test.tsx 'expected length 6, got 7': the model added its NavLink (7 links) without bumping the test's expected count. The fast UI gate ran 'bun run test -- run src/features', which EXCLUDES the AppSidebar test (src/components/core/AppSidebar) — so the count mismatch was invisible during the loop and only failed at final acceptance, after the feature was already frozen 'verified'. Every nav-adding feature MUST edit the shared sidebar (reachability), so this fails ~every feature; the guide asks the model to bump the count but nothing GATED it, making compliance stochastic (build37 bumped it → green; build39 didn't → stuck). Fix: the fast UI test run now includes src/components/core/AppSidebar, so the count mismatch is an in-loop gate error the model must fix (one tiny test file, negligible cost). Gate test asserts the new scope + documents why. Full core suite green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gap (build39)
Company passed the fast per-feature gate (verified 1/1) but failed final acceptance on
AppSidebar.test.tsx— "expected length 6, got 7". Every feature must add its NavLink to the sharedsrc/components/core/AppSidebar(reachability), and that component's co-located test asserts the exact nav-link count. The fast UI gate ranbun run test -- run src/features, which excludessrc/components/core/AppSidebar, so the count mismatch was invisible during the loop and only surfaced at the final fullvalidate— after the feature was frozen "verified".The guide already asks the model to bump the count, but nothing gated it, so compliance was stochastic (build37 bumped it → final GREEN; build39 didn't → stuck). Because it hits every nav-adding feature, it fails final acceptance on essentially every build unless the model happens to comply.
Fix
The fast UI test run now includes the AppSidebar dir:
bun run test -- run src/features src/components/core/AppSidebarso the count mismatch is an in-loop gate error the model must fix before the feature verifies — one tiny extra test file, negligible added time. This is the same gate-parity principle already applied to the feature test suite (a fast-gate-green feature must not fail a test only the final gate ran).
Tests
boringstack-gate.test.tsasserts the new fast-gate scope and documents why. Full core suite green. Panel PASS.🤖 Generated with Claude Code