[as2_gazebo_assets] Remove fixed name from sdf plugin joint controller #820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pariaspe
requested changes
Aug 11, 2025
| <model name="two_fingers_gripper"> | ||
| <pose | ||
| relative_to="base_link"> | ||
| {{ sensor.pose }} |
There was a problem hiding this comment.
Pure SDF files should not include templating
There was a problem hiding this comment.
Hi @pariaspe, why do we keep the SDF file in sensors if we use the jinja file?
There was a problem hiding this comment.
Just in case you want to use the model without templating and our custom launching system
| </geometry> | ||
| <material> | ||
| <script> | ||
| <name>"loquesea"</name> |
|
Hi @carmendrpr, has you done the requested changes? |
Yes. The SDF file does not support templating. I set the default namespace to "/drone0." This namespace is commonly used as the default in most projects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points