Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix: Add .zip extension to Windows package downloads for Expand-Archive Compatibility #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Fix: Add .zip extension to Windows package downloads for Expand-Archive Compatibility #916

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4dc2ed4
Fix: specify filename during Windows package download
priyagupta108 Jul 25, 2024
6e017cd
Changed unit test download urls
priyagupta108 Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Changed unit test download urls
  • Loading branch information
@priyagupta108
priyagupta108 committed Jul 31, 2024
commit 6e017cde5642752138eec818796d09e622d3209c
6 changes: 4 additions & 2 deletions 6 __tests__/utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,8 @@ describe('getDownloadFileName', () => {
it('should return the correct path on Windows', () => {
if (IS_WINDOWS) {
process.env['RUNNER_TEMP'] = tempDir;
const downloadUrl = 'https://example.com/file.zip';
const downloadUrl =
'https://github.com/actions/sometool/releases/tag/1.2.3-20200402.6/sometool-1.2.3-win32-x64.zip';
const expectedPath = path.join(
process.env.RUNNER_TEMP,
path.basename(downloadUrl)
Expand All @@ -188,7 +189,8 @@ describe('getDownloadFileName', () => {

it('should return undefined on non-Windows', () => {
if (!IS_WINDOWS) {
const downloadUrl = 'https://example.com/file.tar.gz';
const downloadUrl =
'https://github.com/actions/sometool/releases/tag/1.2.3-20200402.6/sometool-1.2.3-linux-x64.tar.gz';
expect(getDownloadFileName(downloadUrl)).toBeUndefined();
}
});
Expand Down
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.