Fix: Add .zip extension to Windows package downloads for Expand-Archive Compatibility
#916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priya-kinthali
approved these changes
Jul 26, 2024
aparnajyothi-y
approved these changes
Jul 31, 2024
gowridurgad
approved these changes
Aug 2, 2024
mahabaleshwars
approved these changes
Aug 2, 2024
HarithaVattikuti
approved these changes
Aug 5, 2024
This was referenced Aug 8, 2024
5 tasks
|
I realize that this is a little late, but the code base can be simplified by removing all checks and use of Powershell here. Since the Powershell commands for archive are based on the dotnet APIs it would be much more efficient and less error prone to call them directly. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request addresses compatibility issues on Windows by ensuring that filename for Python and PyPy package downloads explicitly include the
.zipextension. This change allows theExpand-Archivecommand to function correctly on Windows self-hosted runners.Related issue:
#819
#904
Check list: