Create check-dist.yml#212
Create check-dist.yml#212dmitry-shibanov merged 3 commits intoactions:mainactions/setup-java:mainfrom brcrista:brcrista/check-distCopy head branch name to clipboard
Conversation
|
No need for this, see #206 |
|
@konradpabjan @maxim-lobanov @KengoTODA I think there's value in using the same mechanism for all 1st-party actions. For Though I think the value is just in consistency, I don't think same job vs. different job is a huge deal. |
I agree, it would be great for consistency to share the same mechanism. I don't quite remember when the previous check was added but it doesn't make sense for there to be multiple ones. My vote goes towards getting rid of the existing one and using what's in the PR |
|
Hello @brcrista. Thank you for your pull request. Could you please remove this step and the verify-no-unstaged-changes.sh file. |
This adds a workflow to check the contents of the checked-in
dist/index.jsagainst the expected version.See actions/upload-artifact#227 for background and rationale.