Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add check-dist.yml#206

Closed
konradpabjan wants to merge 1 commit intomainactions/setup-java:mainfrom
konradpabjan/check-distactions/setup-java:konradpabjan/check-distCopy head branch name to clipboard
Closed

Add check-dist.yml#206
konradpabjan wants to merge 1 commit intomainactions/setup-java:mainfrom
konradpabjan/check-distactions/setup-java:konradpabjan/check-distCopy head branch name to clipboard

Conversation

@konradpabjan
Copy link
Contributor

This adds a workflow to check the contents of the checked-in dist/index.js against the expected version.

See actions/upload-artifact#227 for background and rationale.

Similar PR: actions/download-artifact#108

@KengoTODA
Copy link
Contributor

note that we have similar comparison in the build.yml:

- name: Verify no unstaged changes
if: runner.os != 'windows'
run: bash __tests__/verify-no-unstaged-changes.sh

It runs verify-no-unstaged-changes.sh in the __tests__ dir.

@maxim-lobanov
Copy link
Contributor

@konradpabjan , agree with @KengoTODA . In build.yml we do pretty similar check: https://github.com/actions/setup-java/blob/main/__tests__/verify-no-unstaged-changes.sh
I think it should be enough.

@konradpabjan
Copy link
Contributor Author

🤦‍♂️ Disregard. Thanks everyone!

@konradpabjan konradpabjan deleted the konradpabjan/check-dist branch May 19, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.