Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

v4 - Remove azureedge.net fallback logic and update install scripts - #572

#572
Merged
HarithaVattikuti merged 10 commits into
mainactions/setup-dotnet:mainfrom
remove-fallback-cdn-logic-v4actions/setup-dotnet:remove-fallback-cdn-logic-v4Copy head branch name to clipboard
Feb 12, 2025
Merged

v4 - Remove azureedge.net fallback logic and update install scripts#572
HarithaVattikuti merged 10 commits into
mainactions/setup-dotnet:mainfrom
remove-fallback-cdn-logic-v4actions/setup-dotnet:remove-fallback-cdn-logic-v4Copy head branch name to clipboard

Conversation

@zaataylor

@zaataylor zaataylor commented Jan 2, 2025

Copy link
Copy Markdown
Collaborator

In response to dotnet/install-scripts#559, we want to remove the CDN fallback logic added for v4 in #566 and update the install scripts once those changes are completed.

This PR currently:

  • Removes the fallback logic
  • Adds in the update install script

Related issue: dotnet/install-scripts#559

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@zaataylor zaataylor changed the title v4- Remove logic for azureedge.net fallback and update install scripts v4- Remove azureedge.net fallback logic and update install scripts Jan 2, 2025
@zaataylor zaataylor changed the title v4- Remove azureedge.net fallback logic and update install scripts v4 - Remove azureedge.net fallback logic and update install scripts Jan 2, 2025
@richlander

Copy link
Copy Markdown

In reference to: #570

Ben Wells and others added 6 commits January 29, 2025 21:22
* upgrade cache to 4.0.0

* license update

* failure fix

* e2e failure fix
* Create dependabot.yml

* update latest install scripts
Bumps [actions/publish-immutable-action](https://github.com/actions/publish-immutable-action) from 0.0.3 to 0.0.4.
- [Release notes](https://github.com/actions/publish-immutable-action/releases)
- [Commits](actions/publish-immutable-action@0.0.3...v0.0.4)

---
updated-dependencies:
- dependency-name: actions/publish-immutable-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump @actions/http-client from 2.2.1 to 2.2.3

Bumps [@actions/http-client](https://github.com/actions/toolkit/tree/HEAD/packages/http-client) from 2.2.1 to 2.2.3.
- [Changelog](https://github.com/actions/toolkit/blob/main/packages/http-client/RELEASES.md)
- [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/http-client)

---
updated-dependencies:
- dependency-name: "@actions/http-client"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix for the check failures

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Aparna Jyothi <aparnajyothi-y@github.com>
* Bump undici from 5.28.4 to 5.28.5

Bumps [undici](https://github.com/nodejs/undici) from 5.28.4 to 5.28.5.
- [Release notes](https://github.com/nodejs/undici/releases)
- [Commits](nodejs/undici@v5.28.4...v5.28.5)

---
updated-dependencies:
- dependency-name: undici
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix for the check failures

* fix for licensed check failure

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Aparna Jyothi <aparnajyothi-y@github.com>
@zaataylor

Copy link
Copy Markdown
Collaborator Author

The changes from main added above include the update install script, now I'll do the same for the other PRs.

@zaataylor
zaataylor marked this pull request as ready for review January 29, 2025 21:41
@zaataylor
zaataylor requested a review from a team as a code owner January 29, 2025 21:41
Comment thread .github/workflows/e2e-tests.yml Outdated
@HarithaVattikuti
HarithaVattikuti merged commit 83c0c1a into main Feb 12, 2025
COMPUTERS-bit pushed a commit to COMPUTERS-bit/setup-dotnet that referenced this pull request Jun 26, 2025
…ts (actions#572)

* Remove logic for azureedge.net fallback in preparation for install script changes

* remove extra spacing

* Update README.md (actions#587)

* upgrade cache from 3.2.4 to 4.0.0 (actions#586)

* upgrade cache to 4.0.0

* license update

* failure fix

* e2e failure fix

* Configure Dependabot settings (actions#585)

* Create dependabot.yml

* update latest install scripts

* Bump actions/publish-immutable-action from 0.0.3 to 0.0.4 (actions#590)

Bumps [actions/publish-immutable-action](https://github.com/actions/publish-immutable-action) from 0.0.3 to 0.0.4.
- [Release notes](https://github.com/actions/publish-immutable-action/releases)
- [Commits](actions/publish-immutable-action@0.0.3...v0.0.4)

---
updated-dependencies:
- dependency-name: actions/publish-immutable-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @actions/http-client from 2.2.1 to 2.2.3 (actions#592)

* Bump @actions/http-client from 2.2.1 to 2.2.3

Bumps [@actions/http-client](https://github.com/actions/toolkit/tree/HEAD/packages/http-client) from 2.2.1 to 2.2.3.
- [Changelog](https://github.com/actions/toolkit/blob/main/packages/http-client/RELEASES.md)
- [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/http-client)

---
updated-dependencies:
- dependency-name: "@actions/http-client"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix for the check failures

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Aparna Jyothi <aparnajyothi-y@github.com>

* Bump undici from 5.28.4 to 5.28.5 (actions#596)

* Bump undici from 5.28.4 to 5.28.5

Bumps [undici](https://github.com/nodejs/undici) from 5.28.4 to 5.28.5.
- [Release notes](https://github.com/nodejs/undici/releases)
- [Commits](nodejs/undici@v5.28.4...v5.28.5)

---
updated-dependencies:
- dependency-name: undici
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix for the check failures

* fix for licensed check failure

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Aparna Jyothi <aparnajyothi-y@github.com>

* Remove old URLs from E2E tests workflow

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Ben Wells <benwells@github.com>
Co-authored-by: aparnajyothi-y <147696841+aparnajyothi-y@users.noreply.github.com>
Co-authored-by: HarithaVattikuti <73516759+HarithaVattikuti@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Aparna Jyothi <aparnajyothi-y@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.