fix: use --upgrade rather than --ignore-installed to upgrade pip
#268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes left over files when upgrading pip.
mayeut
commented
May 4, 2024
Comment on lines
+108
to
+112
| - name: Delete macOS /Library/Frameworks/Python.framework | ||
| if: matrix.platform == 'darwin' | ||
| shell: bash | ||
| run: if [ -d /Library/Frameworks/Python.framework ]; then sudo rm -rf /Library/Frameworks/Python.framework; fi | ||
|
|
There was a problem hiding this comment.
This is required because current macos-11 runners come with 2 outdated pip dist-info.
When installing from pkg, these will be left alone and only one out of the 2 outdated version will be removed by --upgrade thus failing the tests.
Once runners are using fixed installs of Python, this block can removed.
Merged
aparnajyothi-y
approved these changes
May 8, 2024
priyagupta108
approved these changes
May 8, 2024
priya-kinthali
approved these changes
May 8, 2024
HarithaVattikuti
approved these changes
May 8, 2024
This was referenced May 14, 2024
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes left over files when upgrading pip.
See #254 for more information on the issues fixed by this PR:
pip-23.2.dist-infoinsite-packagessetup-python#785Extends #254 by adding a test & fixing
installers/macos-pkg-setup-template.shCloses #254