Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Use --upgrade instead of --ignore-installed to upgrade pip. #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Use --upgrade instead of --ignore-installed to upgrade pip. #254

wants to merge 1 commit into from

Conversation

ezio-melotti
Copy link

@ezio-melotti ezio-melotti commented Jan 3, 2024 •
edited
Loading

This PR fixes the following issues:

I tried running both commands in a test venv.

Using --ignore-installed leaves behind pip-23.2.dist-info:

$ python3 -m && source venv/bin/activate
$ ls venv/lib64/python3.11/site-packages/ | grep pip
pip
pip-23.2.dist-info
$ python -m pip install --ignore-installed pip --disable-pip-version-check --no-warn-script-location --root-user-action=ignore
Collecting pip
  Obtaining dependency information for pip from https://files.pythonhosted.org/packages/15/aa/3f4c7bcee2057a76562a5b33ecbd199be08cdb4443a02e26bd2c3cf6fc39/pip-23.3.2-py3-none-any.whl.metadata
  Using cached pip-23.3.2-py3-none-any.whl.metadata (3.5 kB)
Using cached pip-23.3.2-py3-none-any.whl (2.1 MB)
Installing collected packages: pip
Successfully installed pip-23.3.2
$ ls venv/lib64/python3.11/site-packages/ | grep pip
pip
pip-23.2.dist-info
pip-23.3.2.dist-info
$ deactivate && rm -rf venv

Using --upgrade instead of --ignore-installed removes the old version (see the Attempting uninstall: pip part in the output), upgrades pip from 23.2 to 23.3.2, and doesn't leave pip-23.2.dist-info behind:

$ python3 -m && source venv/bin/activate
$ ls venv/lib64/python3.11/site-packages/ | grep pip
pip
pip-23.2.dist-info
$ python -m pip install --upgrade pip --disable-pip-version-check --no-warn-script-location --root-user-action=ignore
Requirement already satisfied: pip in ./venv/lib/python3.11/site-packages (23.2)
Collecting pip
  Obtaining dependency information for pip from https://files.pythonhosted.org/packages/15/aa/3f4c7bcee2057a76562a5b33ecbd199be08cdb4443a02e26bd2c3cf6fc39/pip-23.3.2-py3-none-any.whl.metadata
  Using cached pip-23.3.2-py3-none-any.whl.metadata (3.5 kB)
Using cached pip-23.3.2-py3-none-any.whl (2.1 MB)
Installing collected packages: pip
  Attempting uninstall: pip
    Found existing installation: pip 23.2
    Uninstalling pip-23.2:
      Successfully uninstalled pip-23.2
Successfully installed pip-23.3.2
$ ls venv/lib64/python3.11/site-packages/ | grep pip
pip
pip-23.3.2.dist-info

Note that:

  • just removing --ignore-installed is not enough, since no upgrade takes place unless --upgrade is also added
  • the --ignore-installed has been there since the beginning (c641695)
  • I'm not 100% sure this will fix the linked issue, nor I'm sure how to verify/test that

@ezio-melotti ezio-melotti requested a review from a team as a code owner January 3, 2024 04:33
@mayeut mayeut mentioned this pull request May 4, 2024
Merged
This was referenced May 14, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ezio-melotti
Morty Proxy This is a proxified and sanitized view of the page, visit original site.