Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[instrument_builder] Add filename validation on save#10919

Open
victori444 wants to merge 2 commits into
aces:29.0-releaseaces/Loris:29.0-releasefrom
victori444:2026_07_15_Instrument_Builder_Filename_Validationvictori444/Loris:2026_07_15_Instrument_Builder_Filename_ValidationCopy head branch name to clipboard
Open

[instrument_builder] Add filename validation on save#10919
victori444 wants to merge 2 commits into
aces:29.0-releaseaces/Loris:29.0-releasefrom
victori444:2026_07_15_Instrument_Builder_Filename_Validationvictori444/Loris:2026_07_15_Instrument_Builder_Filename_ValidationCopy head branch name to clipboard

Conversation

@victori444

@victori444 victori444 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Brief summary of changes

Adds validation to the instrument builder module that prevents file names that aren't properly formatted from being saved. This includes files that:

  • Contain spaces
  • Contain special characters with the exception of "_"
  • Contain multiple periods (aside from the extension period)
  • End with a special character
Screenshot 2026-07-15 at 4 26 32 PM

Testing instructions (if applicable)

  1. In the instrument builder, upload a linst file
  2. In the save tab, test different file names in the first input box that break the rules set above
  3. Verify that error messages appear accordingly and prevent the user from saving unless the file name respect each condition

Link(s) to related issue(s)

@github-actions github-actions Bot added Language: Javascript PR or issue that update Javascript code Module: instrument_builder PR or issue related to instrument_builder module labels Jul 15, 2026
@victori444 victori444 added 29.0.0 - Bugs Issues found during the release testing for 29.0.0 Module: instrument_builder PR or issue related to instrument_builder module Language: Javascript PR or issue that update Javascript code and removed Language: Javascript PR or issue that update Javascript code Module: instrument_builder PR or issue related to instrument_builder module labels Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

29.0.0 - Bugs Issues found during the release testing for 29.0.0 Language: Javascript PR or issue that update Javascript code Module: instrument_builder PR or issue related to instrument_builder module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[instrument_builder] Builder lets you save with file names that are not accepted to be loaded

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.