Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[server_processes_manager] Translate server_processes_manager in french#10755

Open
HachemJ wants to merge 6 commits into
aces:29.0-releaseaces/Loris:29.0-releasefrom
HachemJ:TranslateServerProcessesManagerInFrenchHachemJ/Loris:TranslateServerProcessesManagerInFrenchCopy head branch name to clipboard
Open

[server_processes_manager] Translate server_processes_manager in french#10755
HachemJ wants to merge 6 commits into
aces:29.0-releaseaces/Loris:29.0-releasefrom
HachemJ:TranslateServerProcessesManagerInFrenchHachemJ/Loris:TranslateServerProcessesManagerInFrenchCopy head branch name to clipboard

Conversation

@HachemJ

@HachemJ HachemJ commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Brief summary of changes

This PR translates the server_processes_manager module into French.

Link(s) to related issue(s)

@github-actions github-actions Bot added Language: Javascript PR or issue that update Javascript code Module: server_processes_manager PR or issue related to the server_processes_manger Multilingual Any tasks related to making LORIS multilingual labels Jul 3, 2026
@HachemJ HachemJ mentioned this pull request Jul 3, 2026
6 tasks
@HachemJ HachemJ changed the title Translate server_processes_manager in french [server_processes_manager] Translate server_processes_manager in french Jul 3, 2026
@HachemJ HachemJ added the 29.0.0 - Bugs Issues found during the release testing for 29.0.0 label Jul 20, 2026
@lapadulamichael lapadulamichael self-assigned this Jul 20, 2026
@lapadulamichael

Copy link
Copy Markdown
Contributor

@HachemJ
image
Should we also do these in this PR?

@driusan

driusan commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

"unknown" seems reasonable.. the "text de sortie" might not be possible if it comes from the database and has the pid as part of the string that's coming from the db

@HachemJ

HachemJ commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

"unknown" seems reasonable.. the "text de sortie" might not be possible if it comes from the database and has the pid as part of the string that's coming from the db

image

Yea. probably not. @lapadulamichael I will implement the "unknown" change though. It's a miss on my end.

@lapadulamichael lapadulamichael added the State: Needs work PR awaiting additional work by the author to proceed label Jul 22, 2026
msgstr "Identifiant du processus"

msgid "Type"
msgstr "Type"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used in biobank, bvl_feedback, electrophysiology_browser, genomic_browser and here. Would be worth moving it to the loris namespace

@HachemJ
HachemJ force-pushed the TranslateServerProcessesManagerInFrench branch from 20f5653 to aa953cb Compare July 24, 2026 00:51
@github-actions github-actions Bot added the Module: genomic_browser PR or issue related to genomic_browser module label Jul 24, 2026
@HachemJ
HachemJ force-pushed the TranslateServerProcessesManagerInFrench branch from aa953cb to 466d46d Compare July 24, 2026 00:54
@HachemJ
HachemJ force-pushed the TranslateServerProcessesManagerInFrench branch from 466d46d to cd5d3bd Compare July 24, 2026 00:56
@HachemJ

HachemJ commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

"unknown" seems reasonable.. the "text de sortie" might not be possible if it comes from the database and has the pid as part of the string that's coming from the db

image Yea. probably not. @lapadulamichael I will implement the "unknown" change though. It's a miss on my end.

I intentionally avoided adding a database translation for unknown. Although the value comes from the database (RB_server_processes.sql), it’s also used in other modules, so I felt it belonged in the shared LORIS namespace instead of adding server_processes db translation files for a single string. In this table, 'unknown' is the only "translatable" value and everything else is either dynamic data (e.g. PID, exit code, user ID, start time) or file paths, which don’t require translation.

Translating 'unknown' in the React layer using the shared LORIS namespace seemed like the cleanest approach.

Untitled 20

@github-actions github-actions Bot added Module: bvl_feedback PR or issue related to bvl_feedback module Module: electrophysiology_browser PR or issue related to electrophysiology_browser module labels Jul 24, 2026
@HachemJ HachemJ removed State: Needs work PR awaiting additional work by the author to proceed Module: bvl_feedback PR or issue related to bvl_feedback module Module: electrophysiology_browser PR or issue related to electrophysiology_browser module labels Jul 24, 2026
@HachemJ
HachemJ requested a review from lapadulamichael July 24, 2026 01:19
@github-actions github-actions Bot added Module: bvl_feedback PR or issue related to bvl_feedback module Module: electrophysiology_browser PR or issue related to electrophysiology_browser module labels Jul 24, 2026

@lapadulamichael lapadulamichael left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lapadulamichael lapadulamichael added the Passed manual tests PR has been successfully tested by at least one peer label Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

29.0.0 - Bugs Issues found during the release testing for 29.0.0 Language: Javascript PR or issue that update Javascript code Module: bvl_feedback PR or issue related to bvl_feedback module Module: electrophysiology_browser PR or issue related to electrophysiology_browser module Module: genomic_browser PR or issue related to genomic_browser module Module: server_processes_manager PR or issue related to the server_processes_manger Multilingual Any tasks related to making LORIS multilingual Passed manual tests PR has been successfully tested by at least one peer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.