fix: The web service in docker-compose.yml had no healthcheck, so#2200
Open
singlaamitesh wants to merge 1 commit into
aboutcode-org:mainaboutcode-org/scancode.io:mainfrom
singlaamitesh:fix/1842-scancode-io-1842singlaamitesh/scancode.io:fix/1842-scancode-io-1842Copy head branch name to clipboard
Open
fix: The web service in docker-compose.yml had no healthcheck, so#2200singlaamitesh wants to merge 1 commit intoaboutcode-org:mainaboutcode-org/scancode.io:mainfrom singlaamitesh:fix/1842-scancode-io-1842singlaamitesh/scancode.io:fix/1842-scancode-io-1842Copy head branch name to clipboard
web service in docker-compose.yml had no healthcheck, so#2200singlaamitesh wants to merge 1 commit into
aboutcode-org:mainaboutcode-org/scancode.io:mainfrom
singlaamitesh:fix/1842-scancode-io-1842singlaamitesh/scancode.io:fix/1842-scancode-io-1842Copy head branch name to clipboard
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1842
Summary
The
webservice in docker-compose.yml had no healthcheck, sodocker compose up -d --waitonly waited for the container to be running, not for its migrate/collectstatic steps to finish, letting a subsequentdocker compose run --rm web scanpipe ...race ahead of the DB schema (issue #1842's 'relation scanpipe_project does not exist'). Added a wait-for-it-based healthcheck toweb(with a port-8001 override in docker-compose.dev.yml) so--waittruly waits for readiness, and added a regression test asserting the web service defines a healthcheck.Changes
docker-compose.ymldocker-compose.dev.ymlscanpipe/tests/test_scancodeio.pyHow this was tested
Ran
the affected testslocally.