[MISC] Bump qdrant server to v1.16.1 to match client pin#2046
[MISC] Bump qdrant server to v1.16.1 to match client pin#2046
Conversation
sdk1 pins qdrant-client>=1.16.0,<1.17.0 but the compose stack still ran v1.8.3. The 1.16 client calls REST endpoints the 1.8 server lacks, returning 404 with an empty body, silently breaking all indexing and vector search. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Summary by CodeRabbit
WalkthroughThe Qdrant service in the dev docker-compose configuration is upgraded from image v1.8.3 to v1.16.1. An expanded comment documents the requirement that client and server versions must align, and describes the failure mode (404 errors with empty response bodies) when versions are mismatched. ChangesQdrant Service Update
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docker/docker-compose-dev-essentials.yaml (1)
120-122: ⚡ Quick winClarify version alignment constraint in comment.
The comment states "Server major must track qdrant-client pin," but the version constraint is actually on
major.minor, not justmajor. Both v1.8.3 and v1.16.1 share major version1, but the incompatibility stems from the minor version difference (8 vs. 16). The client pin>=1.16.0,<1.17.0constrains the minor version to16.📝 Proposed fix to improve comment precision
- # Server major must track qdrant-client pin in unstract/sdk1/pyproject.toml; + # Server version must track qdrant-client pin in unstract/sdk1/pyproject.toml;🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docker/docker-compose-dev-essentials.yaml` around lines 120 - 122, Update the explanatory comment in docker-compose-dev-essentials.yaml to say that the server must track the qdrant-client major.minor (not just major) so minor-version mismatches (e.g., server v1.8.x vs client pinned >=1.16.0,<1.17.0) cause incompatible endpoints; adjust the text around the existing "Server major must track qdrant-client pin" line to explicitly mention "major.minor" and the example minor versions (8 vs 16) to clarify the constraint.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@docker/docker-compose-dev-essentials.yaml`:
- Around line 120-122: Update the explanatory comment in
docker-compose-dev-essentials.yaml to say that the server must track the
qdrant-client major.minor (not just major) so minor-version mismatches (e.g.,
server v1.8.x vs client pinned >=1.16.0,<1.17.0) cause incompatible endpoints;
adjust the text around the existing "Server major must track qdrant-client pin"
line to explicitly mention "major.minor" and the example minor versions (8 vs
16) to clarify the constraint.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 18a52df9-b74c-4c93-8ba2-93e4202dd8ff
📒 Files selected for processing (1)
docker/docker-compose-dev-essentials.yaml
|
| Filename | Overview |
|---|---|
| docker/docker-compose-dev-essentials.yaml | Bumps qdrant image from v1.8.3 to v1.16.1 and adds a comment guiding future maintainers to keep the server minor version in sync with the qdrant-client pin in sdk1/pyproject.toml |
Sequence Diagram
sequenceDiagram
participant SDK as unstract/sdk1 (qdrant-client >=1.16)
participant Server as qdrant server
Note over SDK,Server: Before this PR (server v1.8.3)
SDK->>Server: "POST /collections/{name}/points (1.16 REST API)"
Server-->>SDK: 404 (empty body — endpoint missing)
Note over SDK: Silent indexing failure
Note over SDK,Server: After this PR (server v1.16.1)
SDK->>Server: "POST /collections/{name}/points (1.16 REST API)"
Server-->>SDK: 200 OK
Note over SDK: Indexing succeeds
Reviews (2): Last reviewed commit: "Merge branch 'main' into misc/qdrant-bum..." | Re-trigger Greptile
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Signed-off-by: Chandrasekharan M <117059509+chandrasekharan-zipstack@users.noreply.github.com>
|
Summary
sdk1pinsqdrant-client>=1.16.0,<1.17.0but compose was still runningqdrant/qdrant:v1.8.3404with an empty body — silently breaking all document indexing and vector search in the dev compose stackv1.16.1and adds a comment to keep client and server versions in sync going forwardTest plan
VERSION=test docker compose -f docker-compose.yaml -f compose.override.yaml up -d qdrantand confirm container starts healthy🤖 Generated with Claude Code