Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[MISC] Bump qdrant server to v1.16.1 to match client pin#2046

Merged
chandrasekharan-zipstack merged 3 commits into
mainZipstack/unstract:mainfrom
misc/qdrant-bump-1.16Zipstack/unstract:misc/qdrant-bump-1.16Copy head branch name to clipboard
Jun 12, 2026
Merged

[MISC] Bump qdrant server to v1.16.1 to match client pin#2046
chandrasekharan-zipstack merged 3 commits into
mainZipstack/unstract:mainfrom
misc/qdrant-bump-1.16Zipstack/unstract:misc/qdrant-bump-1.16Copy head branch name to clipboard

Conversation

@chandrasekharan-zipstack

Copy link
Copy Markdown
Contributor

Summary

  • sdk1 pins qdrant-client>=1.16.0,<1.17.0 but compose was still running qdrant/qdrant:v1.8.3
  • The 1.16 client calls REST endpoints the 1.8 server lacks, returning 404 with an empty body — silently breaking all document indexing and vector search in the dev compose stack
  • Bumps server image to v1.16.1 and adds a comment to keep client and server versions in sync going forward

Test plan

  • Run VERSION=test docker compose -f docker-compose.yaml -f compose.override.yaml up -d qdrant and confirm container starts healthy
  • Run a document indexing operation and confirm it completes without 404 errors

🤖 Generated with Claude Code

sdk1 pins qdrant-client>=1.16.0,<1.17.0 but the compose stack still ran
v1.8.3. The 1.16 client calls REST endpoints the 1.8 server lacks, returning
404 with an empty body, silently breaking all indexing and vector search.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b55fef39-c9ca-466e-9899-a04bd4655dfa

📥 Commits

Reviewing files that changed from the base of the PR and between 3802e8b and 4fdcaaf.

📒 Files selected for processing (1)
  • docker/docker-compose-dev-essentials.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • docker/docker-compose-dev-essentials.yaml

Summary by CodeRabbit

  • Chores

    • Updated backend service to a newer stable version.
  • Documentation

    • Enhanced documentation regarding service version compatibility requirements.

Walkthrough

The Qdrant service in the dev docker-compose configuration is upgraded from image v1.8.3 to v1.16.1. An expanded comment documents the requirement that client and server versions must align, and describes the failure mode (404 errors with empty response bodies) when versions are mismatched.

Changes

Qdrant Service Update

Layer / File(s) Summary
Qdrant version and documentation
docker/docker-compose-dev-essentials.yaml
Qdrant container image bumped to v1.16.1 from v1.8.3, with expanded comment documenting client/server version alignment requirements and mismatch behavior.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description provides a clear summary of the problem and solution, but is missing most required template sections including 'What', 'Why', 'How', the breaking changes assessment, and other structured sections. Fill in all required template sections: explicitly state what changed in 'What', explain the version mismatch impact in 'Why', describe the fix in 'How', address breaking changes, and complete remaining sections.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically identifies the main change: bumping the qdrant server version to v1.16.1 to align with the client pin, which is the primary objective of the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch misc/qdrant-bump-1.16

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
docker/docker-compose-dev-essentials.yaml (1)

120-122: ⚡ Quick win

Clarify version alignment constraint in comment.

The comment states "Server major must track qdrant-client pin," but the version constraint is actually on major.minor, not just major. Both v1.8.3 and v1.16.1 share major version 1, but the incompatibility stems from the minor version difference (8 vs. 16). The client pin >=1.16.0,<1.17.0 constrains the minor version to 16.

📝 Proposed fix to improve comment precision
-    # Server major must track qdrant-client pin in unstract/sdk1/pyproject.toml;
+    # Server version must track qdrant-client pin in unstract/sdk1/pyproject.toml;
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docker/docker-compose-dev-essentials.yaml` around lines 120 - 122, Update the
explanatory comment in docker-compose-dev-essentials.yaml to say that the server
must track the qdrant-client major.minor (not just major) so minor-version
mismatches (e.g., server v1.8.x vs client pinned >=1.16.0,<1.17.0) cause
incompatible endpoints; adjust the text around the existing "Server major must
track qdrant-client pin" line to explicitly mention "major.minor" and the
example minor versions (8 vs 16) to clarify the constraint.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@docker/docker-compose-dev-essentials.yaml`:
- Around line 120-122: Update the explanatory comment in
docker-compose-dev-essentials.yaml to say that the server must track the
qdrant-client major.minor (not just major) so minor-version mismatches (e.g.,
server v1.8.x vs client pinned >=1.16.0,<1.17.0) cause incompatible endpoints;
adjust the text around the existing "Server major must track qdrant-client pin"
line to explicitly mention "major.minor" and the example minor versions (8 vs
16) to clarify the constraint.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 18a52df9-b74c-4c93-8ba2-93e4202dd8ff

📥 Commits

Reviewing files that changed from the base of the PR and between cafcca7 and 3802e8b.

📒 Files selected for processing (1)
  • docker/docker-compose-dev-essentials.yaml

@greptile-apps

greptile-apps Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Bumps the qdrant server image in the dev-essentials compose file from v1.8.3 to v1.16.1 to match the qdrant-client>=1.16.0,<1.17.0 pin in sdk1/pyproject.toml, fixing silent 404 failures during document indexing and vector search in the dev stack.

  • Updates qdrant/qdrant:v1.8.3qdrant/qdrant:v1.16.1 in docker-compose-dev-essentials.yaml.
  • Adds an inline comment instructing maintainers to keep the server minor version aligned with the client pin whenever the client dependency is updated.

Confidence Score: 5/5

Safe to merge — single-line image tag bump with an explanatory comment; no logic changes.

The change is a one-line image version bump in a dev compose file, directly fixing a known 404 mismatch between the pinned client library and the running server. The new version (v1.16.1) matches the client constraint, the previous review comment about wording has been addressed, and there are no other changed files or logic paths to evaluate.

No files require special attention.

Important Files Changed

Filename Overview
docker/docker-compose-dev-essentials.yaml Bumps qdrant image from v1.8.3 to v1.16.1 and adds a comment guiding future maintainers to keep the server minor version in sync with the qdrant-client pin in sdk1/pyproject.toml

Sequence Diagram

sequenceDiagram
    participant SDK as unstract/sdk1 (qdrant-client >=1.16)
    participant Server as qdrant server

    Note over SDK,Server: Before this PR (server v1.8.3)
    SDK->>Server: "POST /collections/{name}/points (1.16 REST API)"
    Server-->>SDK: 404 (empty body — endpoint missing)
    Note over SDK: Silent indexing failure

    Note over SDK,Server: After this PR (server v1.16.1)
    SDK->>Server: "POST /collections/{name}/points (1.16 REST API)"
    Server-->>SDK: 200 OK
    Note over SDK: Indexing succeeds
Loading

Reviews (2): Last reviewed commit: "Merge branch 'main' into misc/qdrant-bum..." | Re-trigger Greptile

Comment thread docker/docker-compose-dev-essentials.yaml Outdated
chandrasekharan-zipstack and others added 2 commits June 12, 2026 14:23
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Signed-off-by: Chandrasekharan M <117059509+chandrasekharan-zipstack@users.noreply.github.com>
@sonarqubecloud

Copy link
Copy Markdown

@chandrasekharan-zipstack chandrasekharan-zipstack merged commit 776d0fd into main Jun 12, 2026
7 checks passed
@chandrasekharan-zipstack chandrasekharan-zipstack deleted the misc/qdrant-bump-1.16 branch June 12, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.