Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

UN-1009 [FIX] Correct LLMWhisperer adapter API key field label from 'Unstract Key' to 'LLMWhisperer Key'#2037

Merged
jaseemjaskp merged 1 commit into
mainZipstack/unstract:mainfrom
UN-1009-llmw-key-labelZipstack/unstract:UN-1009-llmw-key-labelCopy head branch name to clipboard
Jun 19, 2026
Merged

UN-1009 [FIX] Correct LLMWhisperer adapter API key field label from 'Unstract Key' to 'LLMWhisperer Key'#2037
jaseemjaskp merged 1 commit into
mainZipstack/unstract:mainfrom
UN-1009-llmw-key-labelZipstack/unstract:UN-1009-llmw-key-labelCopy head branch name to clipboard

Conversation

@athul-rs

Copy link
Copy Markdown
Contributor

What

  • Renames the unstract_key field's display label from Unstract Key to LLMWhisperer Key in both LLMWhisperer (v1) and LLMWhisperer v2 X2Text adapter JSON schemas.

Why

  • When creating a new LLMWhisperer profile, the API key field was labeled "Unstract Key", which is confusing — the key being asked for is the LLMWhisperer API key obtained from the LLMWhisperer portal (Jira: UN-1009).

How

  • Changed the title of the unstract_key property in unstract/sdk1/.../x2text/llm_whisperer/src/static/json_schema.json and .../llm_whisperer_v2/src/static/json_schema.json.

Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)

  • No. title is display-only in the JSON schema; the property key unstract_key (which backend code and the cloud subscription-plugin schema transform reference) is unchanged.

Database Migrations

  • None

Env Config

  • None

Relevant Docs

  • None

Related Issues or PRs

  • Jira: UN-1009

Dependencies Versions

  • None

Notes on Testing

  • Verified grep -rn '"Unstract Key"' now returns no occurrences in the repo; only the two schema titles changed.

Screenshots

  • N/A (label text change in adapter config form)

Checklist

I have read and understood the Contribution Guidelines.

🤖 Generated with Claude Code

…to 'LLMWhisperer Key'

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d8d47920-6dbe-4d44-957f-08890793944a

📥 Commits

Reviewing files that changed from the base of the PR and between cafcca7 and 995dffe.

📒 Files selected for processing (2)
  • unstract/sdk1/src/unstract/sdk1/adapters/x2text/llm_whisperer/src/static/json_schema.json
  • unstract/sdk1/src/unstract/sdk1/adapters/x2text/llm_whisperer_v2/src/static/json_schema.json

Summary by CodeRabbit

  • UI Improvements
    • Updated user-facing labels for the LLMWhisperer API key configuration field across adapters for clarity and consistency.

Walkthrough

Two JSON schema configuration files for the LLMWhisperer text extraction adapters update the user-facing display label for the unstract_key field from "Unstract Key" to "LLMWhisperer Key". The changes affect both the v1 and v2 adapter versions with identical edits to the schema field metadata.

Changes

Schema Field Label Updates

Layer / File(s) Summary
Schema field label updates for LLMWhisperer adapters
unstract/sdk1/src/unstract/sdk1/adapters/x2text/llm_whisperer/src/static/json_schema.json, unstract/sdk1/src/unstract/sdk1/adapters/x2text/llm_whisperer_v2/src/static/json_schema.json
The user-facing title text for the unstract_key field is updated from "Unstract Key" to "LLMWhisperer Key" in both the v1 and v2 adapter JSON schema configuration files.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: renaming the API key field label from 'Unstract Key' to 'LLMWhisperer Key' in the LLMWhisperer adapters, with the Jira ticket reference.
Description check ✅ Passed The description is comprehensive and follows the template structure with all required sections completed: What, Why, How, breaking changes assessment, migrations, config, docs, related issues, dependencies, testing notes, and screenshots section.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch UN-1009-llmw-key-label

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps

greptile-apps Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes a confusing label on the API key field in both the LLMWhisperer (v1) and LLMWhisperer v2 adapter JSON schemas, renaming the display title of unstract_key from "Unstract Key" to "LLMWhisperer Key". The change is display-only — the underlying property key, backend references, and all validation logic are untouched.

  • Renames unstract_key's title in llm_whisperer/src/static/json_schema.json and llm_whisperer_v2/src/static/json_schema.json.
  • The corresponding description fields still reference "Unstract developer portal"; for full label consistency those could also be updated to name the LLMWhisperer portal explicitly.

Confidence Score: 5/5

Safe to merge — only display label text changed, no functional or schema-structural impact.

The change touches only the title string inside two JSON schema files. The property key unstract_key, all required field lists, backend adapter code, and any plugin schema transforms are entirely unchanged. The only minor follow-up opportunity is aligning the description text ("Unstract developer portal") to match the new label, but that is cosmetic and does not affect correctness.

No files require special attention; both schemas are simple and the change is isolated to a single string per file.

Important Files Changed

Filename Overview
unstract/sdk1/src/unstract/sdk1/adapters/x2text/llm_whisperer/src/static/json_schema.json Renames the display title of unstract_key from "Unstract Key" to "LLMWhisperer Key"; description still references "Unstract developer portal" which is slightly inconsistent with the new label
unstract/sdk1/src/unstract/sdk1/adapters/x2text/llm_whisperer_v2/src/static/json_schema.json Renames the display title of unstract_key from "Unstract Key" to "LLMWhisperer Key"; description text also still reads "Unstract developer portal"

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[JSON Schema\njson_schema.json] -->|parsed by| B[Adapter Config UI]
    B --> C[unstract_key field]
    C --> D["title: 'LLMWhisperer Key'\n(was: 'Unstract Key')"]
    C --> E["description:\n'API key from Unstract developer portal'\n(unchanged)"]
    C --> F["format: password\ntype: string\n(unchanged)"]
    D --> G[User sees 'LLMWhisperer Key'\nlabel in form]
    E --> H[User sees portal\nlink in tooltip/help]
Loading

Fix All in Claude Code

Prompt To Fix All With AI
Fix the following 2 code review issues. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 2
unstract/sdk1/src/unstract/sdk1/adapters/x2text/llm_whisperer/src/static/json_schema.json:28
The `title` has been correctly updated to "LLMWhisperer Key", but the `description` still says "Unstract developer portal". For full consistency, the description could also be updated to name the LLMWhisperer portal explicitly — otherwise the label says "LLMWhisperer Key" while the help text directs users to an "Unstract" portal.

```suggestion
      "description": "API key obtained from the [LLMWhisperer developer portal](https://unstract-api-resource.developer.azure-api.net)"
```

### Issue 2 of 2
unstract/sdk1/src/unstract/sdk1/adapters/x2text/llm_whisperer_v2/src/static/json_schema.json:27
Same pattern as in v1: the `title` now reads "LLMWhisperer Key" but the `description` still directs users to the "Unstract developer portal". The two fields are shown together in the adapter config form, so aligning the portal name keeps the messaging consistent.

```suggestion
      "description": "API key obtained from the [LLMWhisperer portal](https://us-central.unstract.com/landing?selectedProduct=llm-whisperer)"
```

Reviews (1): Last reviewed commit: "UN-1009 Fix LLMWhisperer adapter key fie..." | Re-trigger Greptile

"title": "Unstract Key",
"title": "LLMWhisperer Key",
"format": "password",
"description": "API key obtained from the [Unstract developer portal](https://unstract-api-resource.developer.azure-api.net)"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The title has been correctly updated to "LLMWhisperer Key", but the description still says "Unstract developer portal". For full consistency, the description could also be updated to name the LLMWhisperer portal explicitly — otherwise the label says "LLMWhisperer Key" while the help text directs users to an "Unstract" portal.

Suggested change
"description": "API key obtained from the [Unstract developer portal](https://unstract-api-resource.developer.azure-api.net)"
"description": "API key obtained from the [LLMWhisperer developer portal](https://unstract-api-resource.developer.azure-api.net)"
Prompt To Fix With AI
This is a comment left during a code review.
Path: unstract/sdk1/src/unstract/sdk1/adapters/x2text/llm_whisperer/src/static/json_schema.json
Line: 28

Comment:
The `title` has been correctly updated to "LLMWhisperer Key", but the `description` still says "Unstract developer portal". For full consistency, the description could also be updated to name the LLMWhisperer portal explicitly — otherwise the label says "LLMWhisperer Key" while the help text directs users to an "Unstract" portal.

```suggestion
      "description": "API key obtained from the [LLMWhisperer developer portal](https://unstract-api-resource.developer.azure-api.net)"
```

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Fix in Claude Code

"title": "Unstract Key",
"title": "LLMWhisperer Key",
"format": "password",
"description": "API key obtained from the [Unstract developer portal](https://us-central.unstract.com/landing?selectedProduct=llm-whisperer)"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Same pattern as in v1: the title now reads "LLMWhisperer Key" but the description still directs users to the "Unstract developer portal". The two fields are shown together in the adapter config form, so aligning the portal name keeps the messaging consistent.

Suggested change
"description": "API key obtained from the [Unstract developer portal](https://us-central.unstract.com/landing?selectedProduct=llm-whisperer)"
"description": "API key obtained from the [LLMWhisperer portal](https://us-central.unstract.com/landing?selectedProduct=llm-whisperer)"
Prompt To Fix With AI
This is a comment left during a code review.
Path: unstract/sdk1/src/unstract/sdk1/adapters/x2text/llm_whisperer_v2/src/static/json_schema.json
Line: 27

Comment:
Same pattern as in v1: the `title` now reads "LLMWhisperer Key" but the `description` still directs users to the "Unstract developer portal". The two fields are shown together in the adapter config form, so aligning the portal name keeps the messaging consistent.

```suggestion
      "description": "API key obtained from the [LLMWhisperer portal](https://us-central.unstract.com/landing?selectedProduct=llm-whisperer)"
```

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Fix in Claude Code

@github-actions

Copy link
Copy Markdown
Contributor

Unstract test results

Per-group results

Status Group Tier Passed Failed Errors Skipped Duration (s)
unit-connectors unit 64 12 0 3 17.0
unit-core unit 0 0 2 0 1.2
unit-platform-service unit 9 0 1 0 1.4
unit-prompt-service unit 15 0 0 0 20.3
unit-rig unit 53 0 0 0 3.4
unit-runner unit 11 0 0 0 3.1
unit-sdk1 unit 390 0 0 0 20.8
unit-tool-registry unit 0 0 1 0 1.4
unit-workers unit 0 0 0 0 18.4
TOTAL 542 12 4 3 87.0

Critical paths

⚠️ Critical paths not yet covered

  • auth-login — User can log in and obtain a session cookie. (entry: POST /api/v1/auth/login; declared coverage: no groups declared)
  • adapter-register-llm — Register and validate an LLM adapter. (entry: POST /api/v1/adapter/; declared coverage: no groups declared)
  • workflow-create-execute — Create a workflow, configure source+destination, execute, poll, fetch result. (entry: POST /api/v1/workflow/{id}/execute/; declared coverage: e2e-workflow)
  • api-deployment-run — Deploy a workflow as an API, POST a document, receive structured JSON. (entry: POST /deployment/api/{org}/{name}/; declared coverage: e2e-api-deployment)
  • prompt-studio-fetch-response — Prompt Studio: create project, add prompt, run single-pass, get response. (entry: POST /api/v1/prompt-studio/prompt-studio-tool/{id}/fetch_response/; declared coverage: e2e-prompt-studio)
  • pipeline-etl-execute — Run an ETL pipeline from source connector to destination. (entry: POST /api/v1/pipeline/{id}/execute/; declared coverage: no groups declared)
  • usage-token-tracking — Per-execution token usage is recorded and retrievable. (entry: GET /api/v1/usage/get_token_usage/; declared coverage: no groups declared)
  • workflow-execution-fan-out — Multi-file workflow execution fans out to file-processing workers and rejoins. (entry: internal: backend → rabbitmq → workers/file_processing; declared coverage: no groups declared)
  • callback-result-delivery — Async results are posted back via the callback worker. (entry: internal: workers/callback → backend /internal endpoints; declared coverage: no groups declared)
✅ Covered critical paths
  • tool-sandbox-exec — covered by unit-runner

@jaseemjaskp jaseemjaskp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed across correctness, type design, silent-failure, test-coverage, comment-accuracy, and simplification lenses.

Scope is a 2-line user-facing label change (unstract_key.title: "Unstract Key" → "LLMWhisperer Key") in the v1 and v2 LLMWhisperer x2text schemas.

  • Zero functional risk: only the display title changed; the field key unstract_key (consumed by the backend / sdk1 UNSTRACT_KEY constant) is untouched, so stored adapter configs are unaffected.
  • Complete & consistent: no remaining "Unstract Key" titles anywhere in the repo, and no legacy non-sdk1 copy of these schemas was missed.
  • The only nit — the field description still references the "Unstract developer portal" — is already flagged by greptile on both lines, so nothing new to add.

LGTM.

@jaseemjaskp jaseemjaskp merged commit 48994a1 into main Jun 19, 2026
8 checks passed
@jaseemjaskp jaseemjaskp deleted the UN-1009-llmw-key-label branch June 19, 2026 10:13
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.