No actionable comments were generated in the recent review. 🎉

Summary by CodeRabbit

• Chores
  • Internal improvements to task execution and job queuing systems for enhanced platform reliability and maintainability, modernizing how the system manages background processing and worker coordination.
  • Expanded test suite coverage for task dispatching and queue management to ensure system stability and correct operation of background jobs.

Walkthrough

This PR introduces a task-registration abstraction seam (queue_backend) that wraps Celery task decorators and dispatch calls, enabling future transitions to alternative job substrates (e.g., PG Queue) without rewriting call sites. All worker tasks migrate from direct Celery decorators to @worker_task, dispatch sites route through dispatch(), an IDE callback worker is added, and run-worker.sh gains log/restart management features.

Changes

Queue Backend Seam & Worker Task Unification

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Review feedback addressed — c84a3e8c (now 658ea89e post-rebase onto main)

Below is a one-to-one accounting against each inline finding. 12 of 13 implemented; 1 pushed back on with rationale.

Critical (3/3 fixed)

Important (4/5 fixed, 1 pushed back)

Suggestions (5/5 fixed)

SonarCloud (1/1 fixed)

Push-back on #6 (missing @worker_task healthcheck in ide_callback/worker.py)

This was a deliberate omission, not an oversight. Earlier in the session we walked through whether the healthcheck Celery task in the other 8 worker.py modules is actually load-bearing. Findings:

• No producer enqueues it. Grep across workers/ and backend/ for send_task("…healthcheck…"), dispatch("…healthcheck…"), apply_async, and any .healthcheck invocation returns nothing. The only consumer is tests/test_callback_sanity.py, which is scoped to the callback worker's app (not ide_callback).
• K8s liveness path uses the Python function, not the Celery task. WorkerBuilder.setup_health_monitoring reads WorkerRegistry.get_health_checks(worker_type) and binds the registered check_*_health callables to HealthServer on port 8089. The @worker_task healthcheck Celery task is on a different path entirely.
• run-worker.sh -s does pgrep on the worker process — never invokes the task.

The reviewer's "Effect: anything that does app.send_task('healthcheck', queue='ide_callback') will silently fail to route" is a hypothetical — there's no such caller in-tree, and producing one would require the seam-bypass that the canary now actively forbids.

I called this out explicitly in the original PR-scope Jira comment on UN-3497: "the Celery @worker_task healthcheck boilerplate that exists in the other 8 worker.py files was deliberately dropped here". The reviewer-flagged "inconsistency" is real, but the consistency is with vestigial code in the other 8 modules — the cleanup direction is to remove them, not to add a 9th. I'll file a separate ticket for that cleanup if there's appetite; this PR isn't the right home for it.

Test count

• test_queue_backend_seam.py: 15 → 17 tests
• test_dispatch_sites_characterisation.py: 13 → 14 tests
• Total: 28 → 31 — all green in 1.82s

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Unstract test results

Per-group results

Critical paths

⚠️ Critical paths not yet covered

• auth-login — User can log in and obtain a session cookie. (entry: POST /api/v1/auth/login; declared coverage: no groups declared)
• adapter-register-llm — Register and validate an LLM adapter. (entry: POST /api/v1/adapter/; declared coverage: no groups declared)
• workflow-create-execute — Create a workflow, configure source+destination, execute, poll, fetch result. (entry: POST /api/v1/workflow/{id}/execute/; declared coverage: e2e-workflow)
• api-deployment-run — Deploy a workflow as an API, POST a document, receive structured JSON. (entry: POST /deployment/api/{org}/{name}/; declared coverage: e2e-api-deployment)
• prompt-studio-fetch-response — Prompt Studio: create project, add prompt, run single-pass, get response. (entry: POST /api/v1/prompt-studio/prompt-studio-tool/{id}/fetch_response/; declared coverage: e2e-prompt-studio)
• pipeline-etl-execute — Run an ETL pipeline from source connector to destination. (entry: POST /api/v1/pipeline/{id}/execute/; declared coverage: no groups declared)
• usage-token-tracking — Per-execution token usage is recorded and retrievable. (entry: GET /api/v1/usage/get_token_usage/; declared coverage: no groups declared)
• workflow-execution-fan-out — Multi-file workflow execution fans out to file-processing workers and rejoins. (entry: internal: backend → rabbitmq → workers/file_processing; declared coverage: no groups declared)
• callback-result-delivery — Async results are posted back via the callback worker. (entry: internal: workers/callback → backend /internal endpoints; declared coverage: no groups declared)

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    subgraph CallSites["Call Sites"]
        NT["notification/helper.py\nsend_notification_to_worker"]
        SC["scheduler/tasks.py\n_execute_scheduled_workflow"]
        WT["worker tasks.py x9\n@worker_task decorator"]
    end

    subgraph Seam["queue_backend seam"]
        D["dispatch\ntask_name args kwargs queue"]
        DEC["worker_task\n*args **kwargs"]
    end

    subgraph Celery["Celery substrate today"]
        ST["current_app.send_task"]
        SHT["celery.shared_task"]
    end

    NT --> D
    SC --> D
    WT --> DEC
    D --> ST
    DEC --> SHT

Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
workers/ide_callback/tasks.py:17-18
Unused import left over from the migration. All `@app.task(...)` decorators in this file have been replaced with `@worker_task(...)`, so `current_app as app` is no longer referenced and can be removed.

```suggestion
from queue_backend import worker_task
```

_{Reviews (1): Last reviewed commit: "UN-3497 [FIX] Extract get_worker_pids_on..." | Re-trigger Greptile}