Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

chore: changes to be compatible with YLT v3#2

Draft
ohoareau wants to merge 3 commits into
YellowLabTools:mainYellowLabTools/YellowLabTools-lambda-agent:mainfrom
greenoco:maingreenoco/yellowlabtools-lambda-agent:mainCopy head branch name to clipboard
Draft

chore: changes to be compatible with YLT v3#2
ohoareau wants to merge 3 commits into
YellowLabTools:mainYellowLabTools/YellowLabTools-lambda-agent:mainfrom
greenoco:maingreenoco/yellowlabtools-lambda-agent:mainCopy head branch name to clipboard

Conversation

@ohoareau

@ohoareau ohoareau commented Nov 7, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@gmetais

gmetais commented Jan 7, 2024

Copy link
Copy Markdown
Contributor

Hi Olivier,
Happy New Year!

The "Unhandled Promise Rejection" error you encountered is related to a Puppeteer option called headless: "new" that was introduced in Phantomas.

The fix in Phantomas is not ready yet, so I can't update YLT, but I tested a hotfix on my local docker image.

Here is a line I added to your Dockerfile.lambda file (this command adds a double slash at the beginning of the line 35):

RUN sed -i '35 s/^/\/\//' node_modules/phantomas/lib/browser.js

It might be used as a temporary fix. I'll let you know when the final fix is available.

ohoareau and others added 2 commits July 4, 2024 11:48
this reduces the generated report data's size sent to symphony
(from ~1.1M to 300K on google.com)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.