Update recommendation for lazy loading images beneath the fold#404
Open
kevinfarrugia wants to merge 2 commits into
YellowLabTools:masterYellowLabTools/YellowLabTools:masterfrom
kevinfarrugia:lazy-loadable-images-messagekevinfarrugia/YellowLabTools:lazy-loadable-images-messageCopy head branch name to clipboard
Open
Update recommendation for lazy loading images beneath the fold#404kevinfarrugia wants to merge 2 commits intoYellowLabTools:masterYellowLabTools/YellowLabTools:masterfrom kevinfarrugia:lazy-loadable-images-messagekevinfarrugia/YellowLabTools:lazy-loadable-images-messageCopy head branch name to clipboard
kevinfarrugia wants to merge 2 commits into
YellowLabTools:masterYellowLabTools/YellowLabTools:masterfrom
kevinfarrugia:lazy-loadable-images-messagekevinfarrugia/YellowLabTools:lazy-loadable-images-messageCopy head branch name to clipboard
Conversation
Author
|
I was finally able to run this locally. Seems to work as expected.
|
|
I would change the wording, since the recommendation is coming from a tool. so instead of:
maybe:
This may not be perfect wording either, but it avoids the use of "I". |
Author
|
SGTM. Will wait for @gmetais 's feedback since I tried to keep it consistent with the current wording. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think we should recommend native image lazy loading ahead of JavaScript implementations.